fix: report disabled otel request context

[0XFF-96]

Issue Link: #170

feat: expose instrumented request context state

Core change:

• restore enabled to application/route-level meaning
• add instrumented: span != null && context != null
• use instrumented as the TS discriminator
• update tests for ignorePaths / disabled / otel false

enabled
= otel is enabled by global/route config

instrumented
= this specific request actually has span/context

Checklist

• run npm run test && npm run benchmark --if-present
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[metcoder95]

This is sadly not the fix we should apply, the enabled flag will just state weather or not the otel instrumentation is enabled for the route or the application, not if the handler has been instrumented or not.

A suggestion here will be to add another flag that hints wether or not the handler has been instrumented.
e.g. instrumented

[0XFF-96]

This is sadly not the fix we should apply, the enabled flag will just state weather or not the otel instrumentation is enabled for the route or the application, not if the handler has been instrumented or not.

A suggestion here will be to add another flag that hints wether or not the handler has been instrumented. e.g. instrumented

Hi metcoder, thanks for you review.

I will look into it and see where we can solve this by introducing a new parameter or not.

[0XFF-96]

how the request looks like

stateDiagram-v2
  [*] --> IncomingRequest

  IncomingRequest --> GloballyDisabled: instrumentation.disable()
  IncomingRequest --> RouteDisabled: config.otel = false
  IncomingRequest --> IgnoredPath: ignorePaths matches
  IncomingRequest --> Instrumented: normal request

  GloballyDisabled --> RequestContext
  RouteDisabled --> RequestContext
  IgnoredPath --> RequestContext
  Instrumented --> RequestContext

  RequestContext --> [*]

  GloballyDisabled: enabled = false
  GloballyDisabled: instrumented = false
  GloballyDisabled: span/context = null

  RouteDisabled: enabled = false
  RouteDisabled: instrumented = false
  RouteDisabled: span/context = null

  IgnoredPath: enabled = true
  IgnoredPath: instrumented = false
  IgnoredPath: span/context = null

  Instrumented: enabled = true
  Instrumented: instrumented = true
  Instrumented: span/context = available

Loading

[0XFF-96]

Mutation Test report

Targeted mutants: 7
Killed: 5
Survived: 2
Score: 71.4%
Practical score: 100% if treating span-only/context-only as equivalent under current control flow