Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
path: ./malachite

- name: Install Rust 1.95.0
uses: dtolnay/rust-toolchain@1.95.0
uses: dtolnay/rust-toolchain@1.100.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid Rust toolchain version bump

High Severity

Dependabot bumped dtolnay/rust-toolchain to @1.100.0, but Rust 1.100.0 is not a released toolchain (current stable is 1.97.x). That tag makes the action ask rustup for a nonexistent version, which 404s and fails CI in both codeql.yml and verify-impl.yml. Step names still say Install Rust 1.95.0, and Dockerfile remains on rust:1.95.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 7382fcb. Configure here.


- name: Cache cargo registry + target
uses: Swatinem/rust-cache@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/verify-impl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
find ./malachite -type f -not -path '*/.git/*' -exec touch -d "$commit_ts" {} +

- name: Install Rust 1.95.0
uses: dtolnay/rust-toolchain@1.95.0
uses: dtolnay/rust-toolchain@1.100.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid Rust toolchain version pin

High Severity

For dtolnay/rust-toolchain, the version tag selects the Rust toolchain to install, not an action semver. This Dependabot bump to @1.100.0 therefore requests Rust 1.100.0, which is not a released toolchain (latest stable is 1.97.1). Neither workflow passes an explicit toolchain input, so CI will fail at install time. The previous @1.95.0 pin also matched Dockerfile's rust:1.95 base image.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 723c08a. Configure here.

with:
components: rustfmt, llvm-tools-preview

Expand Down
Loading