chore: remove unused jemalloc configs - #780
Open
topocount wants to merge 3 commits into
Open
Conversation
These configs were not exported and were therefore unused. removing them since they don't seem to be needed. If needed in the future, export them as _rjem_malloc_conf
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 tasks
manan19
added a commit
that referenced
this pull request
Apr 24, 2026
Per PR review (#796), the original commit removed too much. jemalloc remains the global allocator and the tikv-jemallocator / tikv-jemalloc-ctl deps + rocksdb \"jemalloc\" feature stay in place. Only the malloc_conf export — which was unused as topocount noted in the original #780 proposal — is removed. emit_jemalloc_stats and its callers are restored. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a jemalloc configuration export from the crate root, keeping the jemalloc allocator enabled (non-MSVC targets) while dropping a configuration string that was believed to be ineffective/unneeded.
Changes:
- Removed the exported
malloc_confstatic fromsrc/lib.rs, leaving only the global allocator setup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1
to
3
| #[cfg(not(target_env = "msvc"))] | ||
| #[global_allocator] | ||
| static GLOBAL: tikv_jemallocator::Jemalloc = tikv_jemallocator::Jemalloc; |
Diff CoverageDiff: origin/main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/lib.rs:3
- PR description says the jemalloc configs "were not exported". However, the removed block used
#[export_name = "malloc_conf"]on apub static, which does export themalloc_confsymbol at link time. This change therefore removes an (effective) jemalloc runtime configuration and reverts to jemalloc defaults. Please update the PR description to reflect the actual behavior change (or, if the intent is still to configure jemalloc, export the correct symbol name expected bytikv_jemallocator).
#[cfg(not(target_env = "msvc"))]
#[global_allocator]
static GLOBAL: tikv_jemallocator::Jemalloc = tikv_jemallocator::Jemalloc;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These configs were not exported and were therefore unused. removing them since they don't seem to be needed.
If needed in the future, export them as _rjem_malloc_conf