Skip to content

ops: add CI workflow and branch protection setup (closes #2) - #3

Merged
plur9 merged 1 commit into
mainfrom
ops/ci-workflow-issue-2
Jun 28, 2026
Merged

plur9 merged 1 commit into
mainfrom
ops/ci-workflow-issue-2

Conversation

@plur9

@plur9 plur9 commented Jun 27, 2026

Copy link
Copy Markdown
Member

Summary

Adds .github/workflows/ci.yml to enforce automated testing on every push and PR to main.

  • Runs on: push to main, PR targeting main
  • Matrix: Node 20 + 22
  • Steps: pnpm install --frozen-lockfile → typecheck → vitest run
  • Integration tests (bee-smoke, escrow-flow, sepolia) skip gracefully when no live Bee node is available — unit suite (342 tests) runs clean in CI with no external services

What's still needed (human action)

After this PR merges, a repo admin must enable branch protection on main:

  • Go to: Settings → Branches → Add rule → main
  • Enable: Require status checks to pass (select the test job from this workflow)
  • Enable: Require a pull request before merging (1 review)

This closes the silent-regression risk flagged in issue #2 — the podkey derivation Go interop test is the most critical coverage to enforce automatically.

Closes #2

Adds .github/workflows/ci.yml — runs pnpm install + typecheck + vitest
on push and PR to main, across Node 20 and 22.

Integration tests (bee-smoke, escrow-flow, sepolia) skip gracefully when
no live Bee node is present, so the unit suite (342 tests) runs clean in
CI without any external services.

Branch protection must still be enabled manually by a repo admin (require
1 review + require this CI check to pass before merge).

Closes #2.
@plur9

plur9 commented Jun 28, 2026

Copy link
Copy Markdown
Member Author

CTO review: CI green, ready for merge.

CI passing: Node 20 and Node 22 both green. Workflow assessed:

  • Uses current action versions (checkout@v4, pnpm/action-setup@v4, setup-node@v4)
  • frozen-lockfile prevents lockfile mutation in CI
  • Matrix covers both active LTS lines
  • typecheck + test both enforced
  • No security concerns — no secrets, minimal surface area

Cannot approve as author. Branch protection is not yet active on main (that is what this PR enables), so direct merge is possible. Post-merge: Settings -> Branches -> Add rule -> require 'test' status check + 1 PR review on main to close issue #2 fully.

@plur9
plur9 merged commit 20062d9 into main Jun 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ops: add CI workflow and branch protection to main

2 participants