Repository navigation
[BUGFIX] Guard prefix/suffix options in number generation - #767
Merged
extcode merged 1 commit intoOct 11, 2026
Merged
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
extcode
approved these changes
Oct 11, 2026
extcode
left a comment
extcode
left a comment
Owner
There was a problem hiding this comment.
praise: Thank you for fixing this bug. I'll refactor this by replacing all using the TYPO3 ArrayUtility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating an order, invoice, or delivery number without a configured
prefixorsuffixin TypoScript logsPHP Warning: Undefined array key "suffix"(andprefix) fromNumber::generateNumber(), because the two keys are read directly whileformatandoffsetin the same method already use??.This adds the same null-coalescing guard so the number is generated without the affix when it is not configured. No behavior change when the keys are present.
Fixes #766