Skip to content

fix: avoid mutating read options when reading body #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Phillip9587 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: avoid mutating read options when reading body #742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions lib/read.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,38 +79,37 @@ function read (req, res, next, parse, debug, options) {
}

let length
const opts = options
let stream

// read options
const verify = opts.verify
const verify = options.verify

try {
// get the content stream
stream = contentstream(req, debug, opts.inflate)
stream = contentstream(req, debug, options.inflate)
length = stream.length
stream.length = undefined
} catch (err) {
return next(err)
}

// set raw-body options
opts.length = length
opts.encoding = verify
? null
: encoding

// assert charset is supported
if (opts.encoding === null && encoding !== null && !iconv.encodingExists(encoding)) {
if (verify && encoding !== null && !iconv.encodingExists(encoding)) {
return next(createError(415, 'unsupported charset "' + encoding.toUpperCase() + '"', {
charset: encoding.toLowerCase(),
type: 'charset.unsupported'
}))
}

// set raw-body options
const rawBodyOptions = {
length,
encoding: verify ? null : encoding,
limit: options.limit
}

// read body
debug('read body')
getBody(stream, opts, function (error, body) {
getBody(stream, rawBodyOptions, function (error, body) {
if (error) {
let _error

Expand Down