Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ruju4a
force-pushed
the
feature/add_edit_see_questionnaires
branch
from
September 24, 2026 16:51
0c59d2c to
ab69594
Compare
|
🚨 RSpec Tests Report |
1 similar comment
|
🚨 RSpec Tests Report |
ruju4a
marked this pull request as ready for review
September 24, 2026 16:56
This reverts commit 6f9bf45.
|
🚨 RSpec Tests Report |
efg
previously requested changes
Oct 6, 2026
Per reviewer feedback, the hardcoded array in QuestionsController#types has been extracted to Item::QUESTION_TYPES constant in the Item model. This mirrors the pattern already used by Questionnaire::QUESTIONNAIRE_TYPES, makes the list reusable across the codebase, and keeps the controller method clean. - Add Item::QUESTION_TYPES constant to app/models/Item.rb - Update QuestionsController#types to render Item::QUESTION_TYPES - Update spec to assert against Item::QUESTION_TYPES instead of magic numbers
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… /questions routes, use txt/question_type in items_spec Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
efg
dismissed
their stale review
October 8, 2026 14:39
efg is satisfied that the issue has been resolved.
efg
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.