Fix AppHost startup args and expose client setup path#2355
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f32a87734a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| var builderOptions = new DistributedApplicationOptions | ||
| { | ||
| TrustDeveloperCertificate = !HasArgument("--skip-trust-developer-certificate"), | ||
| AllowUnsecuredTransport = HasArgument("--allow-unsecured-transport"), | ||
| DisableDashboard = HasArgument("--disable-dashboard") | ||
| }; |
There was a problem hiding this comment.
Pass AppHost args into the builder options
With this new DistributedApplicationOptions object, the Aspire builder no longer receives the original command line; the official CreateBuilder(options) docs call out setting Args = args so deployment tools can put the AppHost into publish mode. Any aspire publish/manifest-generation invocation that relies on those AppHost arguments will be ignored and run with default builder behavior instead, so add Args = args while keeping the new flag-derived options.
Useful? React with 👍 / 👎.
|
@ejsmith quick product naming check: this PR exposes the existing
Should we standardize this route as |
Summary
--skip-trust-developer-certificate,--allow-unsecured-transport,--disable-dashboard) throughDistributedApplicationOptions.Testing
aspire runonce package restore can complete.Notes
.aspire-homeartifacts; only source changes are included.