Skip to content

Fix AppHost startup args and expose client setup path#2355

Open
niemyjski wants to merge 4 commits into
mainfrom
feature/fix-apphost-and-client-setup
Open

Fix AppHost startup args and expose client setup path#2355
niemyjski wants to merge 4 commits into
mainfrom
feature/fix-apphost-and-client-setup

Conversation

@niemyjski

Copy link
Copy Markdown
Member

Summary

  • Preserve and harden Aspire launch in Codex environment for local startup by writing ASPIRE_HOME, cleaning generated logs in cleanup, and passing CLI flags to skip trust and allow unsecured transport.
  • Make AppHost honor launch flags (--skip-trust-developer-certificate, --allow-unsecured-transport, --disable-dashboard) through DistributedApplicationOptions.
  • Reduce onboarding friction by adding an in-app Client Setup path from project navigation and API Keys table.
  • Add quick-copy Server URL and API key values to Configure page for faster client wiring.

Testing

  • No local test run completed in this pass; runtime restore still depends on environment network/DNS availability for package feeds.
  • Changes are isolated to startup configuration and UI navigation/markup; runtime behavior should be validated with local aspire run once package restore can complete.

Notes

  • Branch intentionally excludes local .aspire-home artifacts; only source changes are included.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f32a87734a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Exceptionless.AppHost/Program.cs Outdated
Comment on lines +8 to +13
var builderOptions = new DistributedApplicationOptions
{
TrustDeveloperCertificate = !HasArgument("--skip-trust-developer-certificate"),
AllowUnsecuredTransport = HasArgument("--allow-unsecured-transport"),
DisableDashboard = HasArgument("--disable-dashboard")
};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pass AppHost args into the builder options

With this new DistributedApplicationOptions object, the Aspire builder no longer receives the original command line; the official CreateBuilder(options) docs call out setting Args = args so deployment tools can put the AppHost into publish mode. Any aspire publish/manifest-generation invocation that relies on those AppHost arguments will be ignored and run with default builder behavior instead, so add Args = args while keeping the new flag-derived options.

Useful? React with 👍 / 👎.

@niemyjski

Copy link
Copy Markdown
Member Author

@ejsmith quick product naming check: this PR exposes the existing /project/{projectId}/configure route more directly, but we currently have mixed labels for the same concept:

  • New project settings route / command palette entry: Client Setup
  • Project layout heading for the configure route: Send Events
  • Existing project-list action: Download & Configure Client (this matches the old Angular wording)

Should we standardize this route as Download & Configure Client for old-site continuity, or is Client Setup the better new-site label since the page is really package install + API key/server URL + sample event setup? I lean toward one canonical label everywhere rather than adding another synonym, but wanted your call before I change the copy across the route, heading, manage button, API keys shortcut, and project action.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
Exceptionless.AppHost 39% 40% 132
Exceptionless.Core 72% 64% 8644
Exceptionless.Insulation 24% 23% 205
Exceptionless.Web 79% 67% 5231
Summary 72% (17185 / 23730) 64% (8760 / 13672) 14212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant