-
Notifications
You must be signed in to change notification settings - Fork 2
Feature/922 make permissions configurable for custom workflows #923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ArBridgeman
merged 25 commits into
main
from
feature/922_make_permissions_configurable_for_custom_workflows
Jul 15, 2026
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
7a832d8
Fix typos in changelogs
ArBridgeman c37d96c
Make permissions block present in workflows that call the custom work…
ArBridgeman 5d7f0ed
Add documentation for new feature
ArBridgeman 620fde3
Add jinja test
ArBridgeman 24cfb7b
Prepare config test
ArBridgeman bea075f
Add extract_permissions
ArBridgeman 92a1ae4
Remove not-maintained workflows from get_workflow_templates - need to…
ArBridgeman c3d2872
Remove now unneeded custom exception as not maintained workflows not …
ArBridgeman 0a36b86
Remove redundant check
ArBridgeman 1ac5e10
Ensure NOT_MAINTAINED_WORKFLOWS are seeded first
ArBridgeman 69e8d14
Tighten wording in documentation
ArBridgeman 30a3ac2
Merge branch 'main' into feature/922_make_permissions_configurable_fo…
ArBridgeman 08f30e6
Apply text changes from reviewers
ArBridgeman 70a9f21
Fix section headings
ArBridgeman c1028c5
Introduce macro for workflow_permissions
ArBridgeman cfc71fe
Introduce macro for workflow_passed_secrets
ArBridgeman 29d22ac
Reduce enum usage
ArBridgeman 98dbec0
Resolve sonar finding
ArBridgeman 3663d2b
Fix type hints
ArBridgeman 5087874
Resolve sonar finding - attempt 2
ArBridgeman d9b094c
Set autoescape=False as unneeded
ArBridgeman 85d2873
Simplify tests as already covered
ArBridgeman f9680a8
Resolve sonar finding - attempt 3
ArBridgeman 923c88e
Resolve sonar finding - attempt 4
ArBridgeman 4e01cdf
Resolve new sonar finding
ArBridgeman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,5 @@ | ||
| # 10.2.1 - 2026-07-08 | ||
|
|
||
| ## Summary | ||
|
|
||
| ## Bug Fix | ||
| ## Bugfixes | ||
|
|
||
| * #920: Ensured extracted secrets are unique and alphabetically sorted from the custom workflows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
exasol/toolbox/templates/github/workflows/_workflow_macros.j2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| (% macro workflow_permissions(workflow_name) -%) | ||
| (% set permissions = custom_workflows[workflow_name].permissions -%) | ||
| (% if permissions -%) | ||
| (% set rendered_permissions -%) | ||
| permissions: | ||
| (% for permission_name, permission_level in permissions.items() %) | ||
| (( permission_name )): (( permission_level )) | ||
| (% endfor -%) | ||
| (% endset -%) | ||
| (( rendered_permissions | trim | indent(width=4, first=true) )) | ||
| (% endif -%) | ||
| (% endmacro %) | ||
|
|
||
| (% macro workflow_passed_secrets(workflow_name) -%) | ||
| (% set secrets = custom_workflows[workflow_name].secrets -%) | ||
| (% if secrets -%) | ||
| (% set rendered_secrets -%) | ||
| secrets: | ||
| (% for secret_name in secrets %) | ||
| (( secret_name )): ${{ secrets.(( secret_name )) }} | ||
| (% endfor -%) | ||
| (% endset -%) | ||
| (( rendered_secrets | trim | indent(width=4, first=true) )) | ||
| (% endif %) | ||
| (% endmacro %) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.