Add disclaimer: debate and disclaimerLink options#1656
Conversation
✅ Deploy Preview for ethereumclassic ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
59c6033 to
fbc1c78
Compare
|
this is unnecessary. what is the premise? |
|
The premise is that we need another disclaimer text for any upcoming articles related to 1559 or other ECIPs/Debates where there are multiple possible outcomes, as discussed in the referred PRs in my original message above. The existing disclaimer options are Note, this PR isn't affecting any existing articles, it only adds the additional The screenshot is included purely for a demonstration of what this disclaimer banner might look like in context, which happened to be the current latest article. |
|
The phrasing is what i am hung up on, not the image or overall concept. "debated" is overly contentious and sounds like we have already reached a state of 'disagree and commit' to the outcome, or risks every post being flagged as debated vs opinion. I agree we need some disclaimer/bannner/tags to denote items under consideration for the community. We do not have a way of settling debates or a way to gauge if there is contention or agreement in any objective way. i understand conceptually this would have been useful for the original olympia posts, and for the collective group of ecips as a whole. "Under consideration for Olympia fork" tag and a sitewide banner explaining the community-calls are guiding the conversations and no date or final ecips have been decided would be my preference |
|
Thanks for the explanation. I agree that the current wording sounds too contentious. How about the following: If this sounds better, I can go ahead and update this along with the i18n. If you prefer something else, let me know. I want to avoid olympia-specific wording here because it is designed to be applied to this and potential other topics. The "read more" link can be specific to 1559. |
|
@realcodywburns I have updated the branch with the approved text and translation. Note that your previous approval was automatically dismissed since I pushed new changes. |
agreed, it seems unnecessary. |
This PR adds support for
In blog post headers, which will render accordingly (The PR is not changing the Fukuii article, that's just an example)
Refs
ethereumclassic/ECIPs#547
#1652
#1649