Skip to content

Add disclaimer: debate and disclaimerLink options#1656

Merged
IstoraMandiri merged 6 commits into
ethereumclassic:masterfrom
IstoraMandiri:debate-disclaimer
Mar 17, 2026
Merged

Add disclaimer: debate and disclaimerLink options#1656
IstoraMandiri merged 6 commits into
ethereumclassic:masterfrom
IstoraMandiri:debate-disclaimer

Conversation

@IstoraMandiri

@IstoraMandiri IstoraMandiri commented Dec 15, 2025

Copy link
Copy Markdown
Collaborator

This PR adds support for

disclaimer: debate
disclaimerLink: https://some-link.here

In blog post headers, which will render accordingly (The PR is not changing the Fukuii article, that's just an example)

image

Refs

ethereumclassic/ECIPs#547

#1652
#1649

@netlify

netlify Bot commented Dec 15, 2025

Copy link
Copy Markdown

Deploy Preview for ethereumclassic ready!

Name Link
🔨 Latest commit 6f0b16c
🔍 Latest deploy log https://app.netlify.com/projects/ethereumclassic/deploys/69b94b679edecc0008af0852
😎 Deploy Preview https://deploy-preview-1656--ethereumclassic.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@realcodywburns

Copy link
Copy Markdown
Member

this is unnecessary. what is the premise?

@IstoraMandiri

IstoraMandiri commented Dec 16, 2025

Copy link
Copy Markdown
Collaborator Author

The premise is that we need another disclaimer text for any upcoming articles related to 1559 or other ECIPs/Debates where there are multiple possible outcomes, as discussed in the referred PRs in my original message above.

The existing disclaimer options are opinion (This article is an opinion piece) and verify (Don't trust, verify) - neither of these were quite right for the 1559 debate. So this PR adds another option debate (This article is part of an ongoing discussion) .

Note, this PR isn't affecting any existing articles, it only adds the additional disclaimer: debate if it's needed going forward. Approving this PR simply adds this option, and does not commit to using it for anything. Merging this PR does not change any content on the website.

The screenshot is included purely for a demonstration of what this disclaimer banner might look like in context, which happened to be the current latest article.

@realcodywburns

Copy link
Copy Markdown
Member

The phrasing is what i am hung up on, not the image or overall concept. "debated" is overly contentious and sounds like we have already reached a state of 'disagree and commit' to the outcome, or risks every post being flagged as debated vs opinion.

I agree we need some disclaimer/bannner/tags to denote items under consideration for the community. We do not have a way of settling debates or a way to gauge if there is contention or agreement in any objective way.

i understand conceptually this would have been useful for the original olympia posts, and for the collective group of ecips as a whole.

"Under consideration for Olympia fork" tag and a sitewide banner explaining the community-calls are guiding the conversations and no date or final ecips have been decided would be my preference

@IstoraMandiri

IstoraMandiri commented Dec 16, 2025

Copy link
Copy Markdown
Collaborator Author

Thanks for the explanation. I agree that the current wording sounds too contentious.

How about the following:

debate:
  title: Under Consideration
  text: This topic is part of an ongoing community discussion. No decisions have been finalized.

If this sounds better, I can go ahead and update this along with the i18n. If you prefer something else, let me know.

I want to avoid olympia-specific wording here because it is designed to be applied to this and potential other topics. The "read more" link can be specific to 1559.

realcodywburns
realcodywburns previously approved these changes Dec 17, 2025

@realcodywburns realcodywburns left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IstoraMandiri

Copy link
Copy Markdown
Collaborator Author

@realcodywburns I have updated the branch with the approved text and translation. Note that your previous approval was automatically dismissed since I pushed new changes.

@realcodywburns realcodywburns left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm still

@chris-mercer

Copy link
Copy Markdown
Member

this is unnecessary. what is the premise?

agreed, it seems unnecessary.

@diega diega left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IstoraMandiri
IstoraMandiri enabled auto-merge March 17, 2026 12:39
@IstoraMandiri
IstoraMandiri merged commit 62dddbf into ethereumclassic:master Mar 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants