Fix SYNC0 start time calculation for 32 bit devices#322
Merged
Conversation
The register is a `u64` so let's just keep using that
jamwaffles
marked this pull request as ready for review
July 21, 2025 10:13
theol0403
pushed a commit
to theol0403/ethercrab
that referenced
this pull request
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Huge thank you to @v-morlock in #311 for getting most of the way there on this. I dug into the root cause myself and ended up adding a bunch of useful debugging along the way, so I hope it's ok if I merge this PR instead of #311 for the 32 bit DC fixes.