Add version field to config.yaml; gate on version 2 recipes#223
Merged
Conversation
msimberg
reviewed
Jun 6, 2025
Comment on lines
+54
to
+57
| # check the version of the recipe | ||
| if self.config["version"] != 2: | ||
| rversion = self.config["version"] | ||
| if rversion == 1: |
Collaborator
There was a problem hiding this comment.
Is version 3 supposed to work here or not? Currently it would, as would version 0.
Do we want to make the new versions backwards compatible, i.e. version 3 recipe works with stackinator version 2? Or the version has to match exactly? The latter is definitely simpler.
Member
Author
There was a problem hiding this comment.
Indeed.
I now generate a different error for versions not in [1,2].
Member
Author
There was a problem hiding this comment.
I am aiming for exact matches: a version of Stackinator will support a specific recipe version.
github-project-automation
Bot
moved this from In Progress
to Done
in stackinator recipe v2 work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add version filed to config.yaml, and generate a meaningful error message for old recipes.
Note, that this does not remove the internal logic for detecting Spack versions, which can be simplified (a lot) after we have proper gating of recipe versions.