Skip to content

Add Dark Mode - #91

Open
RKBoss6 wants to merge 3 commits into
espruino:masterfrom
RKBoss6:darkmode
Open

Add Dark Mode#91
RKBoss6 wants to merge 3 commits into
espruino:masterfrom
RKBoss6:darkmode

Conversation

@RKBoss6

@RKBoss6 RKBoss6 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

This is the new version of #84, in conjunction with BangleApps #4103

Its up on my app loader

Copilot AI review requested due to automatic review settings June 26, 2026 04:15
@RKBoss6
RKBoss6 marked this pull request as draft June 26, 2026 04:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@RKBoss6

RKBoss6 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Right now, in device info, it gets a path from the info that is a local path on the app loader. I don't know ifDEVICEINFO for the bangles are used anywhere else, because then it'll break...

@gfwilliams

Copy link
Copy Markdown
Member

I don't know ifDEVICEINFO for the bangles are used anywhere else, because then it'll break...

Yes, they're used in https://espruino.github.io/EspruinoApps and probably some other forks.

Maybe you can back out the DEVICEINFO changes and instead add DEVICEINFO.find(d=>d.id=="BANGLEJS").img="..." in loader.js in BangleApps? I think it makes sense to put the image path in the repo where the images are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants