Skip to content

Revert "Add dark mode support" #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gfwilliams merged 1 commit into from
Jan 14, 2026
Merged

Revert "Add dark mode support" #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 1 addition & 53 deletions js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ const DEFAULTSETTINGS = {
alwaysAllowUpdate : false, // Always show "reinstall app" button regardless of the version
autoReload: false, // Automatically reload watch after app App Loader actions (removes "Hold button" prompt)
noPackets: false, // Enable File Upload Compatibility mode (disables binary packet upload)
theme: "device" // App Loader theme: light, dark, device
};
let SETTINGS = JSON.parse(JSON.stringify(DEFAULTSETTINGS)); // clone

Expand All @@ -25,9 +24,6 @@ let device = {
connected : false, // are we connected via BLE right now?
appsInstalled : [] // list of app {id,version} of installed apps
};



// FOR TESTING ONLY
/*let LANGUAGE = {
"//":"German language translations",
Expand Down Expand Up @@ -316,19 +312,6 @@ function iframeSetup(options) {
// when iframe is loaded, call 'onInit' with info about the device
iframe.addEventListener("load", function() {
console.log("IFRAME loaded");
// Style custom apps for dark mode
const iframeDoc = iframe.contentDocument || iframe.contentWindow.document;
if (iframeDoc && iframeDoc.body) {
let theme=SETTINGS.theme;
let prefersDark;
if(theme=="device") prefersDark = window.matchMedia('(prefers-color-scheme: dark)').matches;
else prefersDark = (theme=="dark");
let bgColor = prefersDark ? '#2c2c2c' : '#ffffff';
let textColor = prefersDark ? '#FFFFFF' : '#000000';
iframeDoc.body.style.backgroundColor = bgColor;
iframeDoc.body.style.color = textColor;
}

/* if we get a message from the iframe (eg asking to send data to Puck), handle it
otherwise pass to messageHandler because handleCustomApp may want to handle it */
iframe.contentWindow.addEventListener("message",function(event) {
Expand Down Expand Up @@ -1416,8 +1399,7 @@ function loadSettings() {
console.error("Invalid settings");
}
// upgrade old settings
if(!SETTINGS.appsfavouritedThisSession) SETTINGS.appsfavouritedThisSession = DEFAULTSETTINGS.appsfavouritedThisSession;
if(!SETTINGS.theme) SETTINGS.theme = DEFAULTSETTINGS.theme;
if(!SETTINGS.appsfavouritedThisSession) SETTINGS.appsfavouritedThisSession = [];
}
/// Save settings
function saveSettings() {
Expand All @@ -1438,20 +1420,6 @@ function settingsCheckbox(id, name) {
saveSettings();
});
}
function changeThemeVars(theme){
document.documentElement.style.colorScheme = theme;
document.documentElement.setAttribute('data-theme', theme);

}
function applyTheme(theme){
if(theme=="light" || theme=="dark")changeThemeVars(theme);
else{
const prefersDark = window.matchMedia('(prefers-color-scheme: dark)').matches;
const computedTheme = prefersDark ? 'dark' : 'light';
changeThemeVars(computedTheme);
}
}

settingsCheckbox("settings-pretokenise", "pretokenise");
settingsCheckbox("settings-minify", "minify");
settingsCheckbox("settings-settime", "settime");
Expand All @@ -1460,26 +1428,6 @@ settingsCheckbox("settings-autoReload", "autoReload");
settingsCheckbox("settings-nopacket", "noPackets");
loadSettings();

const selectTheme = document.getElementById("settings-theme");
// Update theme and selector only if site has the selector present
if(selectTheme){
selectTheme.value = SETTINGS.theme;
selectTheme.addEventListener("change",event=>{
SETTINGS.theme = event.target.value;
saveSettings();
applyTheme(event.target.value);
});

//apply theme on startup
applyTheme(SETTINGS.theme);
//in case system theme changes, add a listener to update site theme if in device mode
window.matchMedia('(prefers-color-scheme: dark)').addEventListener('change', (e) => {
if(SETTINGS.theme=="device"){
const newTheme = e.matches ? 'dark' : 'light';
changeThemeVars(newTheme);
}
});
}
let btn;

btn = document.getElementById("defaultsettings");
Expand Down