Skip to content

[Launch] Use Bangle.haptic for haptics if available - #4304

Open
RKBoss6 wants to merge 6 commits into
espruino:masterfrom
RKBoss6:patch-2
Open

[Launch] Use Bangle.haptic for haptics if available#4304
RKBoss6 wants to merge 6 commits into
espruino:masterfrom
RKBoss6:patch-2

Conversation

@RKBoss6

@RKBoss6 RKBoss6 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Use Bangle.haptic for haptics if available. Currently it always calls the haptic function, but since it's a core app, it might be better to have it as a setting as well?

Copilot AI review requested due to automatic review settings July 29, 2026 21:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the launch core app to provide selection haptics on devices/firmwares that expose Bangle.haptic, and records the change in the app’s changelog.

Changes:

  • Trigger haptic feedback when an app is selected in the launcher (only if Bangle.haptic exists).
  • Add a changelog entry for the new behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/launch/app.js Adds an existence-guarded Bangle.haptic() call on selection.
apps/launch/ChangeLog Notes the new haptics behavior in version 0.27.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bobrippling
bobrippling requested a review from gfwilliams July 30, 2026 11:05
@bobrippling

bobrippling commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Use Bangle.haptic for haptics if available. Currently it always calls the haptic function, but since it's a core app, it might be better to have it as a setting as well?

Good question - I've tagged Gorden, feel free to in your descriptions (in future) if you think it's relevant too :)

@gfwilliams

Copy link
Copy Markdown
Member

Thanks! Can you do Bangle.haptic("touch") instead please? Then potentially haptics can be disabled just for touch, or drag, or buttons. I wouldn't bother with an option.

@RKBoss6

RKBoss6 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Ah - that's a smart idea, I'll add that in right now

@gfwilliams

Copy link
Copy Markdown
Member

Looks great - thanks! I guess it might be good to add to other launchers too?

@RKBoss6

RKBoss6 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Sounds good! Should we add the different haptics to settings for people to choose specifics then, or just let apps override it?

@gfwilliams

Copy link
Copy Markdown
Member

Should we add the different haptics to settings for people to choose specifics then, or just let apps override it?

What do you mean? like touch, btn, drag? For now I thought we could have it as an app the overwrites Bangle.haptic - let's not overcomplicate it unless someone actually asks for the feature :)

@RKBoss6

RKBoss6 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

I've added the haptics to iconlaunch as well, most other launchers have their own haptics implementations that I didn't feel like touching/removing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants