[r3.6] cl: reuse one converter between consensus and execution withdrawals - #23320
Merged
Merged
Conversation
…23271) Split out of #23105, which grew too large to review in one piece. This is the mechanical, behaviour-neutral part. The conversion between `cltypes.Withdrawal` and `types.Withdrawal` was hand-written at each call site. `cl/cltypes/withdrawal.go` already had a private singular converter, so this exports a plural one and uses it in the two places that built the list by hand: the payload-attributes emitter in the forkchoice stage, and `cacheExecutionBody`. No behaviour change. Both sites produce the same slice as before, including whether it comes back nil — `cacheExecutionBody` keeps returning nil for an empty withdrawals list rather than an empty slice. Part of a series splitting #23105 into reviewable units. The remaining parts follow separately; this one stands alone and depends on nothing else in the series. (cherry picked from commit 67a305d)
AskAlexSharov
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #23271 to release/3.6.
Applied cleanly; no release-branch adaptations were needed.
Part of backporting the series that split #23105. The follow-up parts are not merged to
mainyet and will be backported separately.