[r3.6] execution/stagedsync: hand the trace sets to the apply result instead of copying - #23093
Merged
Conversation
… of copying The publish path allocated two empty maps and copied every entry of the tx's trace sets into them. The tracer is built per tx inside Worker.RunTxTaskNoLock and nothing else keeps a reference, so the result already owns those maps, and the consumer only ranges over them. The block-end result four hundred lines below already assigns them directly.
yperbasis
approved these changes
Aug 7, 2026
awskii
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #23092 to release/3.6. Applied cleanly.
Every premise the change rests on was re-checked against this branch rather than assumed from main:
Workerhas noCallTracerfield; the tracer is a local inRunTxTaskNoLockbuilt per transaction (execution/exec/state.go:533), handing its maps to the result at 561-562.TxResultis not pooled — the onlysync.Poolintxtask.goisqueuePool.applyLogsAndTraces4only ranges over the two maps.finalizedResults[tx-1]is read again at 2747, but only for.Receipt.Green:
execution/stagedsync,execution/tests,rpc/jsonrpc.