[WIP] execution: fix and optimise BAL warmup - #23081
Open
taratorio wants to merge 7 commits into
Open
Conversation
taratorio
requested review from
AskAlexSharov,
mh0lt and
yperbasis
as code owners
August 7, 2026 07:55
AskAlexSharov
left a comment
Collaborator
There was a problem hiding this comment.
Review of the BAL warmup change. One crash bug, and the lifetime fix currently moves work onto the critical path rather than off it.
Comments are ranked by severity. The first is a node-killer; the next three are behaviour changes worth deciding on before this leaves WIP; the rest are cleanups.
The three comments on the BAL fetch are one root cause seen from three angles: the tx owns the bytes, not the parsed structure, so only tx.GetOne needs to be synchronous. Hoisting the decode with it costs a multi-MiB RLP walk on every newPayload, escapes the if !dbg.ReadAhead gate, and — with no header.HasBAL() check — runs on chains where the feature cannot apply.
…verlay-bal # Conflicts: # execution/exec/blocks_read_ahead.go # execution/exec/blocks_read_ahead_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several fixes and improvements (check benchmark results below):
AddHeaderAndBodyand trying to read the BAL bytes from there so it would never see them - essentially our BAL was never read and used for warmup. The fix is to pass the overlay as atx kv.Getterto it.test_account_accessRelevant
test_account_accessmodes, excludingoverhead_baseline=Truecontrols:SAME_MAXMINIMALDIFF_MAXJUMPDESTSLOAD breakdown: