Replace cwrap.BaseCClass

[eivindjahren]

First does some minor clean up in the c code, then replaces cwrap.BaseCClass

[Copilot]

🟡 Changes recommended

The new _BaseCClass lacks an automatic cleanup path for owning wrappers and FortIO::fwrite_error() can now throw during error handling, both of which can cause runtime issues.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR removes the external Python dependency on cwrap by introducing an internal _BaseCClass and migrating the Python wrapper classes (Summary/Grid/ResdataKW/etc.) off cwrap.BaseCClass, alongside some C++/header cleanup (removing util_unlink, switching some headers to #pragma once).

Changes:

• Drop cwrap from Python runtime dependencies and update tests/imports accordingly.
• Introduce python/resdata/_base_c_class.py and migrate multiple Python wrapper classes from BaseCClass to _BaseCClass; migrate SummaryVarType from BaseCEnum to IntEnum.
• Remove util_unlink and replace unlink-on-write-error behavior with std::filesystem operations; modernize several headers to #pragma once.

File summaries

File	Description
uv.lock	Removes cwrap from locked dependency metadata.
tests/rd_tests/test_sum.py	Drops unused cwrap import.
tests/rd_tests/test_grdecl.py	Drops unused cwrap import.
tests/rd_tests/test_fault_blocks.py	Drops unused cwrap import.
setup.py	Removes cwrap from install_requires.
python/resdata/summary/rd_sum.py	Switches Summary to inherit _BaseCClass.
python/resdata/summary/rd_sum_var_type.py	Replaces BaseCEnum with IntEnum.
python/resdata/summary/rd_sum_tstep.py	Switches SummaryTStep to inherit _BaseCClass.
python/resdata/summary/rd_sum_keyword_vector.py	Switches to _BaseCClass and adds __iter__.
python/resdata/resfile/rd_kw.py	Switches ResdataKW to inherit _BaseCClass and adjusts typing.
python/resdata/rd_type.py	Switches ResDataType to inherit _BaseCClass.
python/resdata/grid/rd_region.py	Switches ResdataRegion to inherit _BaseCClass.
python/resdata/grid/rd_grid.py	Switches Grid to inherit _BaseCClass.
python/resdata/grid/faults/layer.py	Switches Layer to inherit _BaseCClass.
python/resdata/grid/faults/fault_block_layer.py	Switches FaultBlockLayer to inherit _BaseCClass.
python/resdata/gravimetry/rd_subsidence.py	Switches ResdataSubsidence to inherit _BaseCClass.
python/resdata/gravimetry/rd_grav.py	Switches ResdataGrav to inherit _BaseCClass.
python/resdata/geometry/surface.py	Switches Surface to inherit _BaseCClass.
python/resdata/geometry/geo_region.py	Switches GeoRegion to inherit _BaseCClass.
python/resdata/geometry/geo_pointset.py	Switches GeoPointset to inherit _BaseCClass.
python/resdata/geometry/cpolyline_collection.py	Switches CPolylineCollection to inherit _BaseCClass.
python/resdata/_base_c_class.py	New internal replacement for cwrap.BaseCClass.
lib/util/util_unlink.cpp	Deletes the platform-specific unlink shim implementation.
lib/resdata/FortIO.cpp	Replaces unlink-on-write-error with std::filesystem::remove and tightens file handling.
lib/include/resdata/rd_units.hpp	Converts header guard to #pragma once and removes C-linkage wrapper.
lib/include/resdata/rd_kw_magic.hpp	Converts header guard to #pragma once and removes C-linkage wrapper.
lib/include/resdata/rd_grav_common.hpp	Converts header guard to #pragma once and removes C-linkage wrapper.
lib/include/resdata/rd_endian_flip.hpp	Converts header guard to #pragma once and removes C-linkage wrapper.
lib/include/ert/util/util.hpp	Removes inclusion of deleted util_unlink.hpp.
lib/include/ert/util/util_unlink.hpp	Deletes the unlink shim header.
lib/include/ert/util/test_work_area.hpp	Converts header guard to #pragma once and removes C-linkage wrapper.
lib/include/ert/util/test_util.hpp	Converts header guard to #pragma once and adjusts linkage for util_abort_test_jump_buffer().
lib/CMakeLists.txt	Removes util_unlink.cpp from the build.

Review details

Suppressed comments (1)

setup.py:146

• This PR removes cwrap from runtime dependencies here, but pyproject.toml still lists cwrap under [dependency-groups].build, which will keep pulling it into common dev/build environments. If cwrap is no longer needed, it should be removed there as well to fully complete the dependency cleanup.

    install_requires=[
        "numpy",
        "pandas",
        "python-dateutil",
        "natsort",
        "typing_extensions",
        "resfo-utilities>=0.4.0",
    ],

• Files reviewed: 32/33 changed files
• Comments generated: 3
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[ajaust]

Nice work.

I seem to have mostly the same comments and questions as Copilot.

[Copilot]

🔵 Needs a closer look

It changes cross-language binding semantics and native ownership/representation broadly, which needs careful human validation beyond automated review.

Review details

• Files reviewed: 54/55 changed files
• Comments generated: 2
• Review effort level: Lite

[Copilot]

🔵 Needs a closer look

The broad cross-language pointer ownership and native lifetime changes warrant final human validation.

Review details

• Files reviewed: 54/55 changed files
• Comments generated: 0 new
• Review effort level: Balanced

[Copilot]

🟡 Changes recommended

It introduces an unresolved public ABI linkage break and leaves the cwrap build dependency in place.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 54/55 changed files
• Comments generated: 2
• Review effort level: Balanced

[Copilot]

🔵 Needs a closer look

The extensive native pointer and ownership migration needs human validation, and dependency/documentation cleanup remains incomplete.

Review details

• Files reviewed: 56/57 changed files
• Comments generated: 2
• Review effort level: Balanced

[Copilot]

🔵 Needs a closer look

It changes native pointer representation and ownership across numerous Python and C++ interfaces.

Review details

• Files reviewed: 58/59 changed files
• Comments generated: 0 new
• Review effort level: Balanced