Potential fix for code scanning alert no. 48: Information exposure through an exception - #14364
Open
frode-aarstad wants to merge 1 commit into
Open
Potential fix for code scanning alert no. 48: Information exposure through an exception#14364frode-aarstad wants to merge 1 commit into
frode-aarstad wants to merge 1 commit into
Conversation
…rough an exception Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
tbwiik
approved these changes
Sep 4, 2026
Contributor
|
Flaky gh actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/equinor/ert/security/code-scanning/48
Use a generic, non-sensitive error message for both:
experiment_state.status.message{"error": ...}Keep detailed diagnostics in server logs using
logger.exception(...)inside theexceptblock. This preserves functionality (request still fails and is reported as failed) without exposing internal exception details to clients.In
src/ert/dark_storage/endpoints/experiment_server.py, update only theexcept Exception as e:block instart_experiment:"Could not start experiment due to an internal error."experiment_state.status.messageto that string (instead of interpolatinge)JSONResponse({"error": generic_message}, status_code=501)(instead of interpolatinge).exception(...)so developers still get stack traces.No new imports or dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.