Avoid pushing screenshots on non-main PRs - #14264
Merged
Merged
Conversation
berland
added
the
release-notes:skip
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14264 +/- ##
=======================================
Coverage 91.94% 91.94%
=======================================
Files 484 484
Lines 33688 33688
=======================================
+ Hits 30973 30974 +1
+ Misses 2715 2714 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
andreas-el
reviewed
Aug 25, 2026
|
|
||
| - name: Get ert PR title | ||
| if: steps.metadata.outputs.outcome == 'failure' && steps.screenshots.outputs.has_new_screenshots == 'true' && steps.metadata.outputs.pr_number != '0' | ||
| if: steps.metadata.outputs.outcome == 'failure' && steps.screenshots.outputs.has_new_screenshots == 'true' && steps.metadata.outputs.pr_number != '0' && steps.target-branch.outputs.base_ref == 'main' |
Contributor
There was a problem hiding this comment.
The logic for running this differs from the other changes. That might be intentional to allow printing, but none of the variables are picked up in other steps not guarded differently. 🤔
Contributor
There was a problem hiding this comment.
What happens if you run this manually, with 0 as the input?
Contributor
Author
|
I will rewrite this PR to not even test screenshots on merge to non-main, testing screenshots can give false negatives. |
The screenshots stored in ert-testdata only targets the main branch of ert. Thus it is meaningless to run this test workflow on other than merges to main, it will likely produce false negatives.
berland
force-pushed
the
skip_screenshots_for_non_main
branch
from
August 25, 2026 07:50
14221fb to
eaf8227
Compare
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ert-testdata is only able to track screenshots belonging to main of ert and merges to any other version branch must therefore be ignored.
Issue
Resolves #14229
Approach
Skip it
git rebase -i main --exec 'just rapid-tests')When applicable
merge screenshot-PR in ert-testdata before merging this PR.