asLib: fix ValueError when a channel maps to ASG with no ASG(DEFAULT)#214
Open
jacquelinegarrahan wants to merge 1 commit into
Open
asLib: fix ValueError when a channel maps to ASG with no ASG(DEFAULT)#214jacquelinegarrahan wants to merge 1 commit into
jacquelinegarrahan wants to merge 1 commit into
Conversation
self._asg values are (rules, inputs) 2-tuples, but the DEFAULT fallback was a
bare list: self._asg_DEFAULT = asg.get('DEFAULT', []). In create(),
`rules, inputs = self._asg.get(group, self._asg_DEFAULT)` then executed
`rules, inputs = []` -> ValueError whenever a PV's ASG was absent and no
ASG(DEFAULT) block was defined. This runs outside the try/except in create(),
so the channel was left restrictive (or the error surfaced through asTest),
wrongly denying access to every default-group channel.
Use an unpackable empty ruleset ([], {}) as the fallback.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 15, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
self._asg values are (rules, inputs) 2-tuples, but the DEFAULT fallback was a
bare list: self._asg_DEFAULT = asg.get('DEFAULT', []). In create(),
rules, inputs = self._asg.get(group, self._asg_DEFAULT)then executedrules, inputs = []-> ValueError whenever a PV's ASG was absent and noASG(DEFAULT) block was defined. This runs outside the try/except in create(),
so the channel was left restrictive (or the error surfaced through asTest),
wrongly denying access to every default-group channel.
Use an unpackable empty ruleset ([], {}) as the fallback.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com