#228 - Support reading custom properties from SDF files during indexing in Bingo Elastic#3701
Open
Mantas-Kovarskas wants to merge 3 commits into
Open
#228 - Support reading custom properties from SDF files during indexing in Bingo Elastic#3701Mantas-Kovarskas wants to merge 3 commits into
Mantas-Kovarskas wants to merge 3 commits into
Conversation
Mantas-Kovarskas
force-pushed
the
issue-228
branch
4 times, most recently
from
a7a882e to
091de55
Compare
Mantas-Kovarskas
force-pushed
the
issue-228
branch
2 times, most recently
from
5a3b3db to
32b4fc6
Compare
Mantas-Kovarskas
force-pushed
the
issue-228
branch
from
32b4fc6 to
c02098b
Compare
Mantas-Kovarskas
force-pushed
the
issue-228
branch
from
c02098b to
e2aabe2
Compare
Mantas-Kovarskas
force-pushed
the
issue-228
branch
from
e2aabe2 to
535ee17
Compare
AlexanderSavelyev
requested changes
Jun 23, 2026
| async with make_repo() as rep: | ||
| result = rep.filter(n="1") | ||
| hits = [item async for item in result] | ||
| assert hits == [] |
Collaborator
There was a problem hiding this comment.
add test for wrong type for custom properties
| allowed = getattr(instance, "_custom_properties", None) | ||
| if allowed: | ||
| try: | ||
| for prop in value_dup.iterateProperties(): |
Collaborator
There was a problem hiding this comment.
add possibility to set "index=false" for some properties
| custom_properties: Optional[Iterable[str]] = kwargs.pop( | ||
| "custom_properties", None | ||
| ) | ||
| self._custom_properties = ( |
Collaborator
There was a problem hiding this comment.
why do we need it?
Collaborator
Author
There was a problem hiding this comment.
Set data structure has better performance than a list - uses hashing instead of checking every element + removes duplicates. And frozen set is used because it is immutable.
Mantas-Kovarskas
force-pushed
the
issue-228
branch
2 times, most recently
from
68a9598 to
5c2d76d
Compare
Mantas-Kovarskas
force-pushed
the
issue-228
branch
from
5c2d76d to
244c7c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1234 – issue name