Repository navigation
feat: typing binary/file responses as List<int> - #854
Draft
maximeroucher wants to merge 2 commits into
Draft
maximeroucher wants to merge 2 commits into
maximeroucher wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #854 +/- ##
==========================================
+ Coverage 63.65% 63.97% +0.32%
==========================================
Files 9 9
Lines 1183 1188 +5
==========================================
+ Hits 753 760 +7
+ Misses 430 428 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
maximeroucher
marked this pull request as draft
August 3, 2026 16:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type binary/file response bodies as
Future<chopper.Response<List<int>>>instead of String/dynamic, so file/stream downloads are properly typed.type: file), 3.0 (type: string, format: binary) and 3.1 (type: string, contentMediaType: ...).$JsonSerializableConverterto returnresponse.bodyBytesfor aList<int>result type instead of JSON-decoding.contentMediaTypefield toSwaggerSchema(OpenAPI 3.1) which the binary detection relies on.Relates to #116 (byte responses support).