Skip to content

Add Health-regained SFX and import file (fixes #1745) - #2847

Open
FinalRed wants to merge 1 commit into
endlessm:mainfrom
FinalRed:fix-health-audio
Open

Add Health-regained SFX and import file (fixes #1745)#2847
FinalRed wants to merge 1 commit into
endlessm:mainfrom
FinalRed:fix-health-audio

Conversation

@FinalRed

@FinalRed FinalRed commented Sep 5, 2026

Copy link
Copy Markdown

Added "Health-regained.wav" audio asset along with its Godot .import configuration file to the UI SFX folder.

he audio file was created by me and is contributed under the project's license :D.

@FinalRed
FinalRed requested a review from a team as a code owner September 5, 2026 21:47

@wjt wjt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than (fixes #1745) in the title of the PR, it needs to be in the description of the PR on a line of its own:

Fixes #1745 

As i noted in the issue:

If it's already an MP3 there is no upside to converting it back to WAV - it will be lossily compressed a second time when exporting the game.

There is an annoying low frequency hum/buzz in that clip.

I think the melody is a little too long, and to me it sounds a bit too sinister for a positive effect!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a UI sound effect.

I think you could put it directly in assets/first_party/sounds, or better, in a new folder assets/first_party/sounds/collectibles/ mirroring the assets/third_party/sounds/collectibles/ folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants