Skip to content

Add a white flash when the player takes damage - #2800

Merged
wjt merged 2 commits into
endlessm:mainfrom
MeLoNaCo:main
Sep 3, 2026
Merged

Add a white flash when the player takes damage#2800
wjt merged 2 commits into
endlessm:mainfrom
MeLoNaCo:main

Conversation

@MeLoNaCo

@MeLoNaCo MeLoNaCo commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

This updates the player's GotHitAnimation node to use white instead of red.

Resolves #1743

@MeLoNaCo
MeLoNaCo requested a review from a team as a code owner August 27, 2026 23:17
@manuq

manuq commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

@MeLoNaCo as you have found, a "got hit" animation already existed, but it was more subtle (the player going from semitransparent to fully visible). Please attach before/after videos so we can see the difference. It very useful attach videos or images in these kind of tasks.

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown

Test build no longer available.

@manuq manuq left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeLoNaCo looks great! Please update the pull request title and description to reflect the actual changes (white, not red). Also the description should have a last line saying "Resolves URL" being URL the link to the task. See https://github.com/endlessm/threadbare/wiki/Contributing#pull-request-descriptions

After you do the changes in title and description, we can merge it.

@MeLoNaCo MeLoNaCo changed the title Add a red flash when the player takes damage. Add a white flash when the player takes damage Sep 1, 2026
@wjt

wjt commented Sep 3, 2026

Copy link
Copy Markdown
Member

@MeLoNaCo You updated the title but not the description. I fixed the description and will merge. Thanks for the contribution!

@wjt
wjt merged commit 1a1299c into endlessm:main Sep 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create damage-received animation for player-character

3 participants