Skip to content

Prepare @glimmer/component for being published and remove @glimmer/env, using export conditions for dev and prod - #21558

Merged
NullVoxPopuli merged 1 commit into
mainfrom
nvp/remove-glimmer-env-it-is-fake
Aug 13, 2026
Merged

Prepare @glimmer/component for being published and remove @glimmer/env, using export conditions for dev and prod#21558
NullVoxPopuli merged 1 commit into
mainfrom
nvp/remove-glimmer-env-it-is-fake

Conversation

@NullVoxPopuli

@NullVoxPopuli NullVoxPopuli commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@glimmer/components build was wrong.

now is fixed (using the same style of build ember-source uses).

Solves this error:

Error: broken "workspace:" reference to @glimmer/env in @glimmer/component
 at publishedInterPackageDeps (file:///opt/hostedtoolcache/node/24.18.0/x64/lib/node_modules/release-plan/dist/interdep.js:42:35)

#21555

You could argue that this is a release-plan bug, sure.

But, no one should be using @glimmer/env anymore anyway.

@NullVoxPopuli NullVoxPopuli changed the title Nvp/remove glimmer env it is fake Prepare @glimmer/component for being published Aug 12, 2026
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

📊 Size report

Tarball size1.2 MB1.2 MB

dist/dev   No changes

File Before (Size / Brotli) After (Size / Brotli)
Total (Includes all files) 2 MB / 489.8 kB 2 MB / 489.8 kB

dist/prod   No changes

File Before (Size / Brotli) After (Size / Brotli)
Total (Includes all files) 1.9 MB / 447.2 kB 1.9 MB / 447.2 kB

smoke-tests/v2-app-template/dist   No changes

File Before (Size / Brotli) After (Size / Brotli)
Total (Includes all files) 340.6 kB / 94.8 kB 340.6 kB / 94.8 kB

smoke-tests/v2-app-hello-world-template/dist   No changes

File Before (Size / Brotli) After (Size / Brotli)
Total (Includes all files) 132.4 kB / 37 kB 132.4 kB / 37 kB

🤖 This report was automatically generated by wyvox/pkg-size

@kategengler

Copy link
Copy Markdown
Member

How did we publish 4 months ago, then?

@NullVoxPopuli

Copy link
Copy Markdown
Contributor Author

Locally, probably something custom

@NullVoxPopuli
NullVoxPopuli force-pushed the nvp/remove-glimmer-env-it-is-fake branch from 51da856 to 9fd2e8b Compare August 13, 2026 14:20

@mansona mansona left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could argue that this is a release-plan bug, sure.

if workspace links were still in the publish that's a pnpm bug not a release-plan bug, are we sure that we are deploying using pnpm publish instead of npm publish?

If this is trying to solve an urgent release problem we should get on a call pronto but I don't think a big change like this should happen without serious discussion just to solve a deployment problem with known alternative fixes

Comment on lines +8 to +9
"development": "./dist/dev/index.js",
"production": "./dist/prod/index.js",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't these a bit generic? I think by default Vite is setting development in dev mode. If we're going to add something like this we shouldn't be doing this in the same PR that is fixing a breaking deployment

"@ember/component": ["../../../types/stable/@ember/component/index.d.ts"],
"@ember/runloop": ["../../../types/stable/@ember/runloop/index.d.ts"]
"@ember/runloop": ["../../../types/stable/@ember/runloop/index.d.ts"],
"@glimmer/env": ["../env/index.ts"]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so is this now lying? it's not got a dependency on @glimmer/env but it's still using the types from it? I don't understand why we need this to be added if we're truely removing the dependency 🤔

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's types for build flags -- we removed the dep, but we still need type-checking to pass, and we compile it away

@mansona mansona left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have had a call with @NullVoxPopuli and all of my concerns have been addressed 👍 tldr we should probably not be using the name @glimmer/env any more because it isn't "real" and it contributes to confusion. This can be fixed in a follow up PR

@NullVoxPopuli NullVoxPopuli changed the title Prepare @glimmer/component for being published Prepare @glimmer/component for being published and remove @glimmer/env, using export conditions for dev and prod Aug 13, 2026
@NullVoxPopuli
NullVoxPopuli merged commit a0c6adf into main Aug 13, 2026
57 checks passed
@NullVoxPopuli
NullVoxPopuli deleted the nvp/remove-glimmer-env-it-is-fake branch August 13, 2026 16:44
@github-actions github-actions Bot mentioned this pull request Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants