Prepare @glimmer/component for being published and remove @glimmer/env, using export conditions for dev and prod - #21558
Conversation
@glimmer/component for being published
📊 Size reportTarball size — dist/dev No changes
dist/prod No changes
smoke-tests/v2-app-template/dist No changes
smoke-tests/v2-app-hello-world-template/dist No changes
🤖 This report was automatically generated by wyvox/pkg-size |
|
How did we publish 4 months ago, then? |
|
Locally, probably something custom |
51da856 to
9fd2e8b
Compare
mansona
left a comment
There was a problem hiding this comment.
You could argue that this is a release-plan bug, sure.
if workspace links were still in the publish that's a pnpm bug not a release-plan bug, are we sure that we are deploying using pnpm publish instead of npm publish?
If this is trying to solve an urgent release problem we should get on a call pronto but I don't think a big change like this should happen without serious discussion just to solve a deployment problem with known alternative fixes
| "development": "./dist/dev/index.js", | ||
| "production": "./dist/prod/index.js", |
There was a problem hiding this comment.
aren't these a bit generic? I think by default Vite is setting development in dev mode. If we're going to add something like this we shouldn't be doing this in the same PR that is fixing a breaking deployment
| "@ember/component": ["../../../types/stable/@ember/component/index.d.ts"], | ||
| "@ember/runloop": ["../../../types/stable/@ember/runloop/index.d.ts"] | ||
| "@ember/runloop": ["../../../types/stable/@ember/runloop/index.d.ts"], | ||
| "@glimmer/env": ["../env/index.ts"] |
There was a problem hiding this comment.
so is this now lying? it's not got a dependency on @glimmer/env but it's still using the types from it? I don't understand why we need this to be added if we're truely removing the dependency 🤔
There was a problem hiding this comment.
it's types for build flags -- we removed the dep, but we still need type-checking to pass, and we compile it away
mansona
left a comment
There was a problem hiding this comment.
I have had a call with @NullVoxPopuli and all of my concerns have been addressed 👍 tldr we should probably not be using the name @glimmer/env any more because it isn't "real" and it contributes to confusion. This can be fixed in a follow up PR
@glimmer/component for being published@glimmer/component for being published and remove @glimmer/env, using export conditions for dev and prod
@glimmer/components build was wrong.now is fixed (using the same style of build ember-source uses).
Solves this error:
#21555
You could argue that this is a release-plan bug, sure.
But, no one should be using
@glimmer/envanymore anyway.