firmware: remove std usage in the bitstream and timers in devices - #26
Open
hansl wants to merge 2 commits into
Open
firmware: remove std usage in the bitstream and timers in devices#26hansl wants to merge 2 commits into
hansl wants to merge 2 commits into
Conversation
Instead relying on using the embedded-hal traits and ESP-IDF version. This is yak shaving to remove std as much as possible and later using embassy where it makes sense. It also makes drivers more testable in the future (with a test timer).
std::io::Read was the last thing tying the bitstream mod to std. The heatshrink decoder already speaks embedded-io, so moving the FPGA driver and the header parser onto the same traits lets the decoder feed the driver directly and removes the ToStd adapter that sat between them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is essentially cleanup in preparation to adding embassy and using async (and reducing the number of threads), also freeing memory.