Add --cpus and --disk-size to vm.py start - #9
Open
pnc wants to merge 1 commit into
Open
Conversation
`-smp` was hardcoded to 1 and the qcow2 overlay to 20G, so the only tunable was --memory. Both are now flags with module-level defaults (MEMORY/CPUS/DISK_SIZE) that the help text interpolates, so the documented default cannot drift from the real one. --cpus defaults to 4, superseding a hand-edit of `-smp 1` to `-smp 4` in the working tree; that is the value we actually want to boot with. The disk is only sized at creation time, so passing --disk-size against an existing .vm/disk.qcow2 compares the request to the overlay's real virtual size (qemu-img info) and prints a note naming both sizes and what `vm.py reset` costs. It does not resize, recreate, or reset anything — silently ignoring the flag was the bug, not the disk. The e2e fixture now passes --cpus/--disk-size explicitly and asserts the guest's nproc and /dev/vda size match, so a regression that drops either flag fails a test instead of going unnoticed. TEST_DISK_SIZE is deliberately not the default for the same reason. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
Updated slop description, please refresh. |
Member
Author
|
Depends on #10 |
pnc
changed the base branch from
todo-6-bridge-self-serve
to
fix-docker-blob-cdn-allowlist
August 5, 2026 15:12
ddellacosta
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slop description:
-smpwas hardcoded to 1 and the qcow2 overlay to 20G, so the only tunable was --memory. Both are now flags with module-level defaults (MEMORY/CPUS/DISK_SIZE) that the help text interpolates, so the documented default cannot drift from the real one.--cpus defaults to 4 now, 1 is just so pokey.
The disk is only sized at creation time, so passing --disk-size against an existing .vm/disk.qcow2 compares the request to the overlay's real virtual size (qemu-img info) and prints a note naming both sizes and what
vm.py resetcosts. It does not resize, recreate, or reset anything.The e2e fixture now passes --cpus/--disk-size explicitly and asserts the guest's nproc and /dev/vda size match, so a regression that drops either flag fails a test instead of going unnoticed. TEST_DISK_SIZE is deliberately not the default for the same reason.