-
Notifications
You must be signed in to change notification settings - Fork 93
docs: document field name conventions for package fields #1246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
roshan13014
wants to merge
2
commits into
elastic:main
Choose a base branch
from
roshan13014:docs/field-name-conventions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−2
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,8 +45,36 @@ spec: | |
| name: | ||
| description: > | ||
| Name of field. Names containing dots are automatically split into | ||
| sub-fields. | ||
| Names with wildcards generate dynamic mappings. | ||
| sub-fields. Names with wildcards generate dynamic mappings. | ||
| Prefer Elastic Common Schema (ECS) field names when a matching field | ||
| exists (use `external: ecs` or define the ECS field explicitly). For | ||
| custom fields, follow the same naming conventions used by Beats and | ||
| ECS: | ||
|
|
||
| - Use lowercase letters and snake_case (underscores) to combine words. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we just add a referece to the upstream links with the conventions? this way they dont get stale if links are updated |
||
| - Prefer dots to group related fields into nested field sets (for | ||
| example `cpu.load`, not `CPULoad`). | ||
| - Avoid repeating the field-set prefix in the leaf name (use | ||
| `host.ip`, not `host.host_ip`). | ||
| - Organise names from general to specific; put unit suffixes last (for | ||
| example `system.memory.used.bytes`). | ||
| - Use common unit suffixes when applicable: `count`, `pct`, `day`, | ||
| `sec`, `ms`, `us`, `ns`, `bytes`, `mb`. | ||
| - Prefer full words over uncommon abbreviations. Accepted Beats | ||
| abbreviations include `avg`, `max`, `min`, `request`, `connection`, | ||
| and `msg`. | ||
| - Use singular or plural forms that match the field content (for | ||
| example `requests_per_sec`, not `request_per_sec`). | ||
| - Do not use a leaf name that collides with a nested object prefix; | ||
| append `.value` to the scalar field in that case (for example | ||
| `workers.value` alongside `workers.busy`). | ||
|
|
||
|
|
||
| See also the Beats naming conventions | ||
| (https://www.elastic.co/docs/extend/beats/event-conventions) and the | ||
| ECS field-name guidelines | ||
| (https://www.elastic.co/docs/reference/ecs/ecs-guidelines). | ||
|
|
||
| type: string | ||
| pattern: '^[\-*_\/@A-Za-z0-9]+(\.[\-*_\/@A-Za-z0-9]+)*$' | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link should be this pr