Skip to content

Use pure user-profile subpaths and theme tokens in security server code - #302023

Open
sphilipse wants to merge 2 commits into
elastic:mainfrom
sphilipse:eui-server-split-security
Open

sphilipse wants to merge 2 commits into
elastic:mainfrom
sphilipse:eui-server-split-security

Conversation

@sphilipse

@sphilipse sphilipse commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Summary

Server consumers of @kbn/user-profile-components import the pure user_profile module instead of the React barrel, removing the @elastic/eui value imports from the server's module graph.

Server consumers of @kbn/user-profile-components import the pure user_profile
module instead of the React barrel, and VISUALIZATION_COLORS is rebuilt from
@elastic/eui-theme-borealis colorVis (verified byte-identical) in the package
and in security's common model, removing the @elastic/eui value imports.

Pure import-path refactor, no behavior change; every target subpath module
already exists on main. Part of removing the browser UI stack from the Kibana
server startup module graph (context and measurements in elastic#300920; enforced at
runtime by elastic#302010 once every part lands).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@sphilipse sphilipse added the release_note:skip Skip the PR/issue when compiling release notes label Oct 30, 2026
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown
Contributor
🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!
  • Click to trigger kibana-entity-store-performance-from-pr for this PR!
  • Click to trigger kibana-storybooks-from-pr for this PR!
  • Click to trigger kibana-static-checks for this PR!

…g VISUALIZATION_COLORS

getUserAvatarColor is the only user-profile helper that needs EUI's
VISUALIZATION_COLORS, and it is only called from browser code. Moving it to
src/user_avatar_color.ts keeps src/user_profile.ts free of @elastic/eui without
hand-rolling the palette from @elastic/eui-theme-borealis.

The security plugin's common/model/user_profile.ts duplicated these helpers; it
now only carries the GetUserProfileResponse type, and the account management
page imports the helpers from @kbn/user-profile-components instead.
@sphilipse
sphilipse marked this pull request as ready for review October 30, 2026 14:37
@sphilipse
sphilipse requested review from a team as code owners October 30, 2026 14:37
@sphilipse
sphilipse requested a review from jeramysoucy October 30, 2026 14:37
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / ConversationsPage decisions submits the selected reason and rationale, and returns to the read-only decided state
  • [job] [logs] Jest Tests #1 / ConversationsPage impact pills clears the filter when the selected pill is clicked again
  • [job] [logs] Jest Tests #1 / LandingPage releases the save lock on total failure so a subsequent worker enable can transition normally
  • [job] [logs] Scout Lane #61 - serverless-search / default / local-serverless-search - Homepage - Admin - body links should navigate to correct URLs when clicked
  • [job] [logs] Scout Lane #61 - serverless-search / default / local-serverless-search - Homepage - Viewer - body links should navigate to correct URLs when clicked
  • [job] [logs] Scout Lane #46 - stateful-classic / default / local-stateful-classic - Built-in roles Kibana access validation - should have expected Kibana access for all built-in roles
  • [job] [logs] Scout Lane #46 - stateful-classic / default / local-stateful-classic - Built-in roles Kibana access validation - should have expected Kibana access for all built-in roles
  • [job] [logs] Scout Lane #39 - stateful-classic / default / local-stateful-classic - Homepage - Admin - body links should navigate to correct URLs when clicked
  • [job] [logs] Scout Lane #39 - stateful-classic / default / local-stateful-classic - Homepage - Viewer - body links should navigate to correct URLs when clicked
  • [job] [logs] Scout Lane #4 - stateful-classic / default / local-stateful-classic - Maps - Lens choropleth chart - should allow creation of choropleth chart
  • [job] [logs] Scout Lane #4 - stateful-classic / default / local-stateful-classic - Maps - Lens choropleth chart - should create choropleth chart from suggestion
  • [job] [logs] FTR Configs #70 / machine learning - anomaly detection - group 1 single metric job cloning with too short of a job creation time range results in validation callouts
  • [job] [logs] FTR Configs #100 / machine learning - anomaly detection - group 1 single metric job cloning with too short of a job creation time range results in validation callouts

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Search & ML UX v9.5.7 v9.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants