Repository navigation
Conversation
Uses a packed build of the EUI breakpoint container branch.
…ner mixin Updates the packed EUI build to include the mixin.
Scope EuiFlyout to the app area wrapper instead of #app-main-scroll, so push padding shrinks the breakpoint container and breakpoints follow the area left next to the flyout.
KibanaEuiProvider renders a hidden span on the first commit, reads its parent and replaces it with the children before paint. EUI then measures the nearest breakpoint container from that element, so JS hooks follow the app area without app changes.
Dosant
added
release_note:skip
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Contributor
Author
|
/ci |
Contributor
💔 Build Failed
Failed CI Steps
Metrics [docs]Page load bundle
Unknown metric groups@kbn/rspack-optimizer bundle module count
total optimizer output size
warm start memory
workflow yaml validation
Test Failures
History |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of elastic/kibana-team#3040
Depends on elastic/eui#10192
CSS only: #296816
Full PoC with both tracks: #296462
Summary
Not for merge. This runs CI with both tracks on, to see what breaks.
Same as the CSS-only PR, plus JS:
KibanaEuiProviderfinds the element its React root is mounted in and passes it to EUI. EUI measures the nearest breakpoint container from there, souseCurrentEuiBreakpoint,EuiShowForandEuiHideForfollow the app area too. No app changes.The provider finds the element with a hidden marker. On the first commit it renders only a
<span hidden>, reads its parent in a layout effect, then renders the children before paint. The cost is one extra commit per root mount. Roots rendered into an element that isn't in the page yet fall back tobody, and getdata-kbn-breakpoint-detachedso they're easy to spot.renderToStaticMarkupruns no layout effects, so string-rendered tooltips skip the marker and render the children right away.To see which roots follow the app area, set
localStorage.kbnSurfacePocDebug = 'true'and reload. Roots inside the app area get a red outline, the rest purple.EUI comes from a packed build of the EUI branch,
elastic_eui_123.1.0_surface_poc_2.tgz.