[aws.cloudtrail] Backport ingest pipeline improvements and bugfixes to backport-aws-6.x - #20972
Conversation
Backport of elastic#20403 to backport-aws-6.x so 8.19.x / 6.x (Kibana 8.x) users receive the CloudTrail ingest pipeline improvements. Brings the cloudtrail data stream to parity with main. Enhancements: - Replace every `ignore_failure: true` with an `ignore_missing` flag, a condition guard, or an explicit `on_failure` handler reporting to `error.message`, so real faults surface instead of being silently swallowed. - Add support for CloudTrail fields that were previously dropped. - Populate the `cloud.provider`, `cloud.service.name` and `related.*` ECS fields. Bugfixes: - Stop populating `file.hash.sha256` on digest records. - Fix `DeleteObject` using an invalid `event.type: delete` (now `deletion`). - Fix `Publish`, `SendCommand` and `Converse` producing no `event.type`. - Fix `retain: none` behaving like `retain: all`. - Fix `retain: keyword`/`minimal` discarding digest and Insights records. - Fix `aws.cloudtrail.service_event_details` surviving `retain: flattened`/`none`. (cherry picked from commit a3291a9, PR elastic#20403)
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
✅ Elastic Docs Style Checker (Vale)No issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
| Add support for CloudTrail fields that were previously dropped. | ||
| Populate the `cloud.provider`, `cloud.service.name` and `related.*` ECS fields. | ||
| type: enhancement | ||
| link: https://github.com/elastic/integrations/pull/20403 |
There was a problem hiding this comment.
Severity: 🟡 Medium confidence: high path: packages/aws/changelog.yml:10
Changelog links a different PR number
Details
The changelog entries added on lines 10, 15, 25 point at pull/20403 (line 10), pull/20318 (line 15), pull/20403 (line 25), but they were added in PR #20972. They are likely leftover template placeholders or copies from another PR.
Recommendation:
Point each added changelog entry's link at this PR:
link: https://github.com/elastic/integrations/pull/20972🤖 AI-Generated Review | Vera Review Bot - v0.3.0 | 📚 Knowledge base: integration-skills
⚠️ Automated review — verify suggestions before applying.
|
🟢 No issues across the latest commits e655c9b. Review summaryIssues found across earlier commits ae4b364 — 1 medium
🤖 AI-Generated Review | Vera Review Bot - v0.3.0 | 📚 Knowledge base: integration-skills
|
|
✅ All changelog entries have the correct PR link. |
|
✅ Package owners are in sync with |
💔 Build Failed
Failed CI StepsHistory
|
Proposed commit message
Note
This is a backport of #20403 to
backport-aws-6.x(the branch that keepsKibana 8.x support for the AWS package). The scope is limited to the
cloudtraildata stream and package-level files (changelog, manifest,validation). No other data streams are modified.
What this includes vs.
maincloudtrailingest pipeline,fields.yml,sample_event.json,data-stream manifest, and pipeline test fixtures are byte-identical to the
merged
mainchange (a3291a9 / [aws.cloudtrail] Ingest Pipeline Improvments and Bugfixes #20403).exist on this branch and is a prerequisite for the [aws.cloudtrail] Ingest Pipeline Improvments and Bugfixes #20403 pipeline.
versionbumped to6.22.0(format_version kept at3.4.0).SVR00009added tovalidation.yml(pre-existing pipeline predates that check).Checklist
changelog.ymlfile.How to test this PR locally
elastic-package stack up -d --version 8.19.4.packages/aws, run:elastic-package test pipeline --data-streams cloudtrail -vRelated issues