Skip to content

[EuiFlyoutMenu] Align menu height with compact AppHeader (49px) - #10211

Merged
ryankeairns merged 3 commits into
mainfrom
rk/sand-down-the-flyout-menu
Oct 15, 2026
Merged

ryankeairns merged 3 commits into
mainfrom
rk/sand-down-the-flyout-menu

Conversation

@ryankeairns

@ryankeairns ryankeairns commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Closes #10202

Important

Kibana coordination
This drops the default EuiFlyoutMenu from 50px → 49px. Discover’s header often still measures 50px (border stacking / TABS_BAR_HEIGHT quirk), so pairing this EUI bump with a Discover AppHeader height fix (true 49px, or a local flyout-menu override if Discover must stay taller) avoids a 1px misalignment.

Please land the Discover/AppHeader change in the same Kibana PR that upgrades EUI to the release containing this change. Reach out to @ryankeairns for Kibana-side input and verification.

👉 Discover reference PR: elastic/kibana#297883
Targeting the data-test-subj is not great, but it works. Tabs in the middle is inherently tricky in dealing with borders.
CleanShot 2026-10-14 at 14 54 59@2x

Summary

  • Sets default EuiFlyoutMenu height to 49px (base * 3 + thinBorder) so it aligns with Kibana’s compact AppHeader (48px + 1px border)
  • Repositions the close button top to size.m so it stays vertically centered in the shorter bar
  • Fixes the 1px overshoot from aiming at Discover’s measured 50px instead of the real design target (#10202)

Test plan

  • Confirm EuiFlyoutMenu container measures 49px in Storybook
  • Confirm close/action buttons remain vertically centered
  • Spot-check push flyout next to a compact app header alignment (or VRT diffs once CI updates baselines)

ryankeairns and others added 2 commits October 14, 2026 10:48
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown

📷 14 visual difference(s) found

Look at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes.

See the visual regression testing wiki for more information.

Expand to review

euiflyout (14 differences)

StoryDiff %BeforeAfterDiff
playground desktop 0.26%
push flyouts desktop 1.00%
with banner desktop 0.51%
with banner no header desktop 0.38%
action states desktop 0.50%
pagination example desktop 0.34%
playground desktop 0.41%
playground mobile 0.56%
push flyouts mobile 3.70%
with banner mobile 1.10%
with banner no header mobile 0.83%
action states mobile 1.50%
pagination example mobile 0.89%
playground mobile 0.73%

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown

📷 14 visual difference(s) found

Look at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes.

See the visual regression testing wiki for more information.

Expand to review

euiflyout (14 differences)

StoryDiff %BeforeAfterDiff
playground desktop 0.26%
push flyouts desktop 1.00%
with banner desktop 0.51%
with banner no header desktop 0.38%
action states desktop 0.50%
pagination example desktop 0.34%
playground desktop 0.41%
playground mobile 0.56%
push flyouts mobile 3.70%
with banner mobile 1.10%
with banner no header mobile 0.83%
action states mobile 1.50%
pagination example mobile 0.89%
playground mobile 0.73%

@ryankeairns
ryankeairns marked this pull request as ready for review October 14, 2026 21:54
@ryankeairns
ryankeairns requested a review from a team as a code owner October 14, 2026 21:54
Copilot AI balanced review requested due to automatic review settings October 14, 2026 21:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The localized styling changes match the stated requirements, with no unresolved findings.

0 open findings

What changed in this PR

Aligns EuiFlyoutMenu with Kibana’s 49px compact AppHeader, addressing #10202.

Changes:

  • Reduces the default menu height from 50px to 49px.
  • Adjusts the close button’s vertical offset.
  • Documents the alignment change in the changelog.
File Description
packages/​eui/​src/​components/​flyout/​flyout_menu/​flyout_menu.styles.ts Updates menu height and close-button positioning.
packages/​eui/​changelogs/​upcoming/​10211.md Notes the new 49px height and alignment intent.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

@ryankeairns
ryankeairns merged commit 0e1ece9 into main Oct 15, 2026
8 checks passed
@ryankeairns
ryankeairns deleted the rk/sand-down-the-flyout-menu branch October 15, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EuiFlyoutMenu] Align menu row height with compact AppHeader (49px, not 50px)

4 participants