Repository navigation
[EuiFlyoutMenu] Align menu height with compact AppHeader (49px) - #10211
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
📷 14 visual difference(s) foundLook at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes. See the visual regression testing wiki for more information. Expand to revieweuiflyout (14 differences)
|
📷 14 visual difference(s) foundLook at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes. See the visual regression testing wiki for more information. Expand to revieweuiflyout (14 differences)
|
There was a problem hiding this comment.
🟢 Approval recommended
The localized styling changes match the stated requirements, with no unresolved findings.
0 open findings
What changed in this PR
Aligns EuiFlyoutMenu with Kibana’s 49px compact AppHeader, addressing #10202.
Changes:
- Reduces the default menu height from 50px to 49px.
- Adjusts the close button’s vertical offset.
- Documents the alignment change in the changelog.
| File | Description |
|---|---|
| packages/eui/src/components/flyout/flyout_menu/flyout_menu.styles.ts | Updates menu height and close-button positioning. |
| packages/eui/changelogs/upcoming/10211.md | Notes the new 49px height and alignment intent. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
💚 Build Succeeded
History
|
💚 Build Succeeded
History
|










































Closes #10202
Important
Kibana coordination
This drops the default EuiFlyoutMenu from 50px → 49px. Discover’s header often still measures 50px (border stacking / TABS_BAR_HEIGHT quirk), so pairing this EUI bump with a Discover AppHeader height fix (true 49px, or a local flyout-menu override if Discover must stay taller) avoids a 1px misalignment.
Please land the Discover/AppHeader change in the same Kibana PR that upgrades EUI to the release containing this change. Reach out to @ryankeairns for Kibana-side input and verification.
👉 Discover reference PR: elastic/kibana#297883

Targeting the data-test-subj is not great, but it works. Tabs in the middle is inherently tricky in dealing with borders.
Summary
EuiFlyoutMenuheight to 49px (base * 3 + thinBorder) so it aligns with Kibana’s compact AppHeader (48px + 1px border)toptosize.mso it stays vertically centered in the shorter barTest plan
EuiFlyoutMenucontainer measures 49px in Storybook