Repository navigation
[EuiIcon] Add ruler icon - #10194
[EuiIcon] Add ruler icon#10194
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The source, generated asset, registration metadata, and snapshot are consistent and complete.
0 open findings
What changed in this PR
Adds the ruler glyph to EuiIcon, including search metadata and test coverage.
Changes:
- Adds the 16×16 ruler SVG and generated React asset.
- Registers
rulerwith measurement-related synonyms. - Adds the rendered icon snapshot.
| File | Description |
|---|---|
packages/eui/src/components/icon/svgs/ruler.svg |
Defines the source glyph. |
packages/eui/src/components/icon/assets/ruler.tsx |
Provides the generated React asset. |
packages/eui/src/components/icon/icon_map.ts |
Registers the icon and search metadata. |
packages/eui/src/components/icon/__snapshots__/icon.test.tsx.snap |
Covers rendered output. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
📷 1 visual difference(s) foundLook at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes. See the visual regression testing wiki for more information. |
📷 1 visual difference(s) foundLook at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes. See the visual regression testing wiki for more information. |
|
The ruler icon looks good! |
📷 1 visual difference(s) foundLook at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes. See the visual regression testing wiki for more information. |
|
buildkite test this |
📷 1 visual difference(s) foundLook at the visual diff below. If everything is expected, run Approve visual changes to update baselines, re-run the job or make appropriate fixes. See the visual regression testing wiki for more information. |
💚 Build Succeeded
History
|
💚 Build Succeeded
History
|
Summary
rulericon toEuiIcon.gearbut want something more specific.tagandpencil) with its corners on whole-pixel grid points, (1,11), (11,1), (15,5) and (5,15), and the 1px safe zone kept clear.tag,pencil,magnify,wrench,key,pin). Its ink stays within the keylines more closely than any of them, and its optical center is within 0.1px of the viewbox center.synonymsmetadata so it shows up in docs icon search.API Changes
rulerglyph iconScreenshots
{Screenshot of the icon at 16/24/32px, light and dark mode}
Impact Assessment
Impact level: 🟢 None. This is an additive new icon.
Release Readiness
Migration guide:QA instructions for reviewer
EuiIconstory in Storybook) and findruler.Checklist before marking Ready for Review
QA: Tested in CodeSandbox and KibanaBreaking changes: Addedbreaking changelabel (if applicable)🤖 Generated with Claude Code