Repository navigation
[Emotion] Memoize EuiHeaderSection styles - #10193
Draft
Anshuman-Prakash wants to merge 1 commit into
Draft
Anshuman-Prakash wants to merge 1 commit into
Anshuman-Prakash wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
👋 Since this is a community submitted pull request, a Buildkite build has not been started automatically. Would an Elastic organization member please verify the contents of this pull request and kick off a build manually? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10156. Part of #10147.
Memoize
EuiHeaderSectionstyles withuseEuiMemoizedStyles(euiHeaderSectionStyles)instead of calling the generator on every render. The generator takes no arguments, so it is already a static function of the theme; thegrow/sidestyle selection stays in the component.API Changes
None.
Screenshots
Not applicable: CSS definitions are unchanged, and all existing header snapshots pass without updates on React 17 and React 18.
Impact Assessment
Impact level: 🟢 Low — performance-only change to reuse generated styles across renders. No expected visual, behavioral, public API, or snapshot changes.
Release Readiness
skip-changelogapplies.QA instructions for reviewer
From
packages/eui:yarn test-unit src/components/header --runInBand— passed: 62 tests, 38 snapshots on React 18.yarn test-unit --react-version=17 src/components/header --runInBand— passed: 62 tests, 38 snapshots on React 17.eslint src/components/header/header_section/andyarn tsc --noEmit— no errors.