Skip to content

[Docs] Remove Example's outer panel border - #10191

Merged
tsullivan merged 1 commit into
elastic:mainfrom
tsullivan:docs/fix-extra-borders
Oct 8, 2026
Merged

tsullivan merged 1 commit into
elastic:mainfrom
tsullivan:docs/fix-extra-borders

Conversation

@tsullivan

@tsullivan tsullivan commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Summary

Closes #10078

Removes an extraneous panel border from the doc site's Example component wrappers.

API Changes

None

Screenshots

Screen recording showing before/after side by side over several fullpage screenshots of the docs site:

eui-docs-example-panel-border-removal-demo-small.mov

Impact Assessment

Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.

  • 🔴 Breaking changes — What will break? How many usages in Kibana/Cloud UI are impacted?
  • 💅 Visual changes — May impact style overrides; could require visual testing. Explain and estimate impact.
  • 🧪 Test impact — May break functional or snapshot tests (e.g., HTML structure, class names, default values).
  • 🔧 Hard to integrate — If changes require substantial updates to Kibana, please stage the changes and link them here.

Impact level: 🟢 None

Release Readiness

  • Documentation: Fixed a docs issue.
  • Figma: N/A
  • Migration guide: N/A
  • Adoption plan (new features): N/A

QA instructions for reviewer

  • Open the docs site locally (e.g., yarn start).
  • Navigate to the theming token pages or any page utilizing the Example component wrapper.
  • Confirm that the extraneous outer panel border is no longer present around the examples.

Checklist before marking Ready for Review

Reviewer checklist

  • Approved Impact Assessment — Acceptable to merge given the consumer impact.
  • Approved Release Readiness — Docs, Figma, and migration info are sufficient to ship.

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

@tsullivan tsullivan added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Oct 7, 2026
@tsullivan
tsullivan marked this pull request as ready for review October 7, 2026 18:01
@tsullivan
tsullivan requested a review from a team as a code owner October 7, 2026 18:01
Copilot AI balanced review requested due to automatic review settings October 7, 2026 18:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused change correctly removes the unwanted border without affecting the component API.

0 open findings

What changed in this PR

Removes the extraneous border around documentation examples.

Changes:

  • Disables the outer EuiSplitPanel border while retaining inner example framing.
File Description
packages/​website/​src/​components/​example/​example.tsx Sets the outer example panel’s hasBorder to false.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@mgadewoll mgadewoll left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 LGTM. Thanks for the cleanup!

@tsullivan
tsullivan merged commit 1675984 into elastic:main Oct 8, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs site has some extraneous panel borders

3 participants