Skip to content

perf(tree_view): memoize EuiTreeView styles with useEuiStylesMemoizer - #10185

Merged
angeles-mzb merged 1 commit into
elastic:mainfrom
as-marin:perf/memoize-tree-view-styles
Oct 15, 2026
Merged

angeles-mzb merged 1 commit into
elastic:mainfrom
as-marin:perf/memoize-tree-view-styles

Conversation

@as-marin

@as-marin as-marin commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

### API Changes
```markdown
No changes to the public EUI API.

Screenshots

No visual changes.

Impact Assessment

- [x] 🔴 **Breaking changes** — None.
- [x] 💅 **Visual changes** — None.
- [x] 🧪 **Test impact** — None. Unit tests passed in both React 17 and 18.
- [x] 🔧 **Hard to integrate** — No.

**Impact level:** 🟢 None

Release Readiness

- [x] **Documentation:** N/A
- [x] **Figma:** N/A
- [x] **Migration guide:** N/A
- [x] **Adoption plan:** N/A

QA instructions for reviewer

- Open the TreeView component in Storybook.
- Confirm that the component renders correctly in both Light and Dark modes.
- Verify that there are no console errors or rendering issues.

Checklist before marking Ready for Review

- [x] Filled out all sections above
- [x] **QA:** Tested [light/dark modes, high contrast](https://devtoolstips.org/tips/en/emulate-forced-colors/), mobile, Chrome/Safari/Edge/Firefox, keyboard-only, screen reader
- [x] **QA:** Tested in [CodeSandbox](https://codesandbox.io/) and [Kibana](https://github.com/elastic/eui/blob/main/wiki/contributing-to-eui/testing/testing-in-kibana.md)
- [x] **QA:** Tested docs changes
- [x] **Tests:** Added/updated [Jest](https://github.com/elastic/eui/blob/main/wiki/contributing-to-eui/testing/unit-testing.md), [Cypress](https://github.com/elastic/eui/blob/main/wiki/contributing-to-eui/testing/cypress-testing.md), and [VRT](https://github.com/elastic/eui/blob/main/wiki/contributing-to-eui/testing/visual-regression-testing.md)
- [x] **Changelog:** Added [changelog entry](https://github.com/elastic/eui/blob/main/wiki/contributing-to-eui/documenting/changelogs.md)
- [x] **Breaking changes:** Added `breaking change` label (if applicable)

@as-marin
as-marin requested a review from a team as a code owner October 7, 2026 06:45
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

👋 Since this is a community submitted pull request, a Buildkite build has not been started automatically. Would an Elastic organization member please verify the contents of this pull request and kick off a build manually?

@github-actions github-actions Bot added the community contribution (Don't delete - used for automation) label Oct 7, 2026
@angeles-mzb

Copy link
Copy Markdown
Contributor

buildkite test this

@angeles-mzb angeles-mzb added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Oct 15, 2026
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

@angeles-mzb angeles-mzb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note, before starting work, it's a good idea to comment on the issue you'd like to tackle so other community contributors see the issue is already being worked on.

Thanks for contributing @as-marin!

@angeles-mzb
angeles-mzb merged commit c8ee461 into elastic:main Oct 15, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community contribution (Don't delete - used for automation) skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Emotion] Memoize EuiTreeView styles

2 participants