Repository navigation
perf(tree_view): memoize EuiTreeView styles with useEuiStylesMemoizer - #10185
Merged
Merged
Conversation
|
👋 Since this is a community submitted pull request, a Buildkite build has not been started automatically. Would an Elastic organization member please verify the contents of this pull request and kick off a build manually? |
Contributor
|
buildkite test this |
💚 Build Succeeded
|
💚 Build Succeeded
|
angeles-mzb
approved these changes
Oct 15, 2026
angeles-mzb
left a comment
Contributor
There was a problem hiding this comment.
As a side note, before starting work, it's a good idea to comment on the issue you'd like to tackle so other community contributors see the issue is already being worked on.
Thanks for contributing @as-marin!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
euiTreeViewStylesto use the memoized styles pattern.useEuiMemoizedStyles.tree_view.tsxto usestylesMemoizerand verified thateuiTreeViewStylesis a static theme-based generator. Dynamic props (likedisplay) are kept outside the memoized function to maintain reactivity.Screenshots
Impact Assessment
Release Readiness
QA instructions for reviewer
Checklist before marking Ready for Review