Fix smart-retry gap in rolling-upgrade-legacy - #156078
Merged
parkertimmins merged 3 commits intoAug 10, 2026
Merged
Conversation
The rolling-upgrade-legacy suite runs its upgrade phases as separate Gradle tasks (oldClusterTest, oneThirdUpgradedTest, etc.). Buildkite's smart-retry can skip tasks that passed in a previous run, but retries start a fresh cluster, so state created by oldClusterTest is gone when oneThirdUpgradedTest runs — causing 404s on indices/data-streams that were never created. Every other rolling-upgrade project already sets smartRetry.pruneIndividualTests.set(false) to prevent this; rolling-upgrade-legacy was simply missing that line. Unmutes DataStreamsUpgradeIT (3 tests), MLModelDeploymentsUpgradeIT, and MlAssignmentPlannerUpgradeIT, all muted for this same reason. Closes elastic#153415
elasticsearchmachine
added
v9.6.0
needs:triage
parkertimmins
added
>test
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
parkertimmins
added
auto-backport
jordan-powers
approved these changes
Aug 6, 2026
jordan-powers
left a comment
jordan-powers
left a comment
Contributor
There was a problem hiding this comment.
Thanks for looking into this!
Contributor
|
Could you add #154593 to the unmutes? Looks like it'll also be fixed by this |
parkertimmins
enabled auto-merge (squash)
August 6, 2026 17:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
rolling-upgrade-legacyruns its upgrade phases as separate Gradle tasks (oldClusterTest,oneThirdUpgradedTest, etc.). Buildkite's smart-retry skips tasks that passed in a previous build attempt, but retries start a fresh cluster — so state created byoldClusterTestis missing whenoneThirdUpgradedTestruns, causing 404s on indices/data streams that were never created.Every other rolling-upgrade project (
qa/rolling-upgrade,x-pack/qa/rolling-upgrade) already setssmartRetry.pruneIndividualTests.set(false)to prevent this.rolling-upgrade-legacywas simply missing that line.Fix
Add
smartRetry.pruneIndividualTests.set(false)torolling-upgrade-legacy/build.gradle.Unmutes five tests that were muted for this exact reason:
#153413
#153414
#153415
#153416
#153417
#154593
Closes #153413
Closes #153414
Closes #153415
Closes #153416
Closes #153417
Closes #154593