Allow blueprint type packages - #3828
Conversation
e32a300 to
8cb4ad3
Compare
| @@ -0,0 +1,16 @@ | |||
| format_version: 3.6.6 | |||
There was a problem hiding this comment.
This should be 3.7.0 or the version the spec contains the support of new type.
| license: "Elastic-2.0" | ||
| conditions: | ||
| kibana: | ||
| version: "^8.0.0" |
There was a problem hiding this comment.
this was one of my feedback doubts; if blueprints are not used by fleet/kibana; does this require a version condition?
teresaromero
left a comment
teresaromero
left a comment
There was a problem hiding this comment.
I would like to have a clear understanding of the new package from the spec side before moving forward on the elastic-package elastic/package-spec#1209
| @@ -0,0 +1,16 @@ | |||
| format_version: 3.6.6 | |||
There was a problem hiding this comment.
This should be 3.7.0 or the version the spec contains the support of new type.
| license: "Elastic-2.0" | ||
| conditions: | ||
| kibana: | ||
| version: "^8.0.0" |
There was a problem hiding this comment.
this was one of my feedback doubts; if blueprints are not used by fleet/kibana; does this require a version condition?
There was a problem hiding this comment.
please uncommit this file
2 participants
Summary
"blueprint"toAllowedPackageTypesso package-root detection recognizes blueprint packages. This unblocksformat,lint,build, andcheckfrom failing early withpackage root not found.elastic-package create packageto scaffold blueprint packages (wizard +--type blueprint): sample IaC underblueprints/, and omitimg/,_dev/, categories, icons, and screenshots to match the upcoming package-spec layout.blueprintlike other non-data-stream package types inPackageHasDataStreams.internal/packages/testdata/blueprint.Closes #3827
Relates to elastic/package-spec#1209 (blueprint package type / dynamic IaC).
Context
A new
blueprintpackage type is being introduced in package-spec for canonical IaC base templates. Without recognizing that type inAllowedPackageTypes, every core command fails before doing real work. This is also a prerequisite for the integrations repo publish pipeline once blueprint packages start landing there.Test plan
go test ./internal/packages/ ./internal/packages/archetype/ ./cmd/ -run 'TestAllowedPackageTypes|TestFindPackageRoot|TestPackage|TestCreatePackage'elastic-package create package --type blueprint --name <tmp>creates a valid-looking package root (manifest typeblueprint,blueprints/present, noimg//_dev)elastic-package format -C internal/packages/testdata/blueprintsucceedsmake build format lint licenser gomod(withCGO_ENABLED=0formake updateif needed in local env)lint/build/checksucceed against the fixture after bumping to a package-spec release that includes theblueprinttype (currently blocked on package-spec#1209; verified locally against that PR tip via a temporary replace)Follow-ups
github.com/elastic/package-spec/v3once the blueprint type ships, then re-runlint/build/checkon the fixture (and optionally move/add a package undertest/packages/for CI coverage).blueprintbefore GA.