Extract ATF#get(Constructor/Method)ReceiverType helpers#1872
Open
wmdietl wants to merge 6 commits into
Open
Conversation
… utility methods This commit fixes an issue where constructor type variable bounds were not being viewpoint-adapted correctly, mirroring the fix that was made for method invocations. It extracts 'getConstructorReceiverType' into a dedicated helper method, adds 'constructorTypeVariableBoundsFromUse', and utilizes it in 'BaseTypeVisitor.visitNewClass'. It also improves API usability by making both 'getMethodReceiverType' and 'getConstructorReceiverType' public and cross-referencing them in Javadocs.
aosen-xiong
reviewed
Jul 17, 2026
| methods.withArg(top); | ||
|
|
||
| // :: error: (type.arguments.not.inferred) | ||
| methods.withArg(a); |
Collaborator
There was a problem hiding this comment.
I think this line should not issue an error.
Let me think about how to combine this with #1850.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done while reviewing an earlier version of #1850 with Antigravity.
@aosen-xiong Is it worth keeping the two new helpers
ATF#get(Constructor/Method)ReceiverType?The extra test case is also useful.