refactor(egg-bin): remove dead --no-tegg bundle flag#5982
Conversation
The `--no-tegg` flag was plumbed from the CLI into egg-bundler's `tegg` option, but `Bundler.run()` never reads that option. tegg decoratedFile collection is driven entirely by whether the manifest contains an `extensions.tegg` block, so the flag was a no-op — passing it changed nothing in the bundle output and only misled users. Remove the flag, its `tegg` option on `BundlerConfig`, the README note, and the related test assertions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (3)
📝 WalkthroughWalkthroughRemoves the ChangesRemove --no-tegg from bundle pipeline
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request removes the unused and unimplemented --no-tegg CLI flag and its corresponding tegg configuration option from the bundler, documentation, and tests. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Deploying egg with
|
| Latest commit: |
7d3d1c5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e3dc1599.egg-cci.pages.dev |
| Branch Preview URL: | https://worktree-remove-dead-no-tegg.egg-cci.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #5982 +/- ##
=======================================
Coverage 85.59% 85.60%
=======================================
Files 669 669
Lines 19892 19904 +12
Branches 3942 3947 +5
=======================================
+ Hits 17026 17038 +12
Misses 2478 2478
Partials 388 388 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Deploying egg-v3 with
|
| Latest commit: |
7d3d1c5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a95b0d3c.egg-v3.pages.dev |
| Branch Preview URL: | https://worktree-remove-dead-no-tegg.egg-v3.pages.dev |
Motivation
The
bundlecommand's--no-teggflag was plumbed from the CLI into@eggjs/egg-bundler'steggoption, butBundler.run()never reads that option. tegg decoratedFile collection is driven entirely by whether the manifest (<baseDir>/.egg/manifest.json) contains a populatedextensions.teggblock — passing--no-teggdid not change the bundle output at all.So the flag was a dead no-op that only misled users into thinking they could disable tegg processing.
Scope
--no-teggflag fromtools/egg-bin/src/commands/bundle.ts(and the now-unusedteggfield it passed through, plus the debug arg).tegg?: booleanoption fromBundlerConfigintools/egg-bundler/src/index.ts(it was never consumed by the bundler).tegg:assertions and--no-teggarg fromtools/egg-bin/test/commands/bundle.test.ts.If a real "force-skip tegg" escape hatch is ever needed, it should be wired properly into
Bundler.run()rather than left as an unconsumed option.Test evidence
vitest run test/commands/bundle.test.ts→ 4 passedtsgo --noEmitclean for bothegg-binandegg-bundler🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
--no-teggCLI flag documentation from bundle command options.Refactor
--no-teggCLI flag has been removed from the bundle command.teggconfiguration option is no longer supported in the bundler configuration.