Skip to content

Support @file context in custom command arguments - #590

Open
emecii wants to merge 3 commits into
editor-code-assistant:masterfrom
emecii:fix/custom-command-file-context
Open

emecii wants to merge 3 commits into
editor-code-assistant:masterfrom
emecii:fix/custom-command-file-context

Conversation

@emecii

@emecii emecii commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • resolve @file custom-command and parameterized-skill arguments after substitution and attach their contents through the existing prompt-context format
  • share path/range parsing with regular prompt contexts, including ~ expansion and trailing ranges on Windows-style paths
  • preserve quoted arguments containing spaces and document the quoting requirement

Fixes #163

Testing

  • clojure -M:test --focus eca.features.commands-test — 27 tests, 199 assertions
  • clojure -M:test --focus eca.features.context-test — 11 tests, 54 assertions
  • clojure -M:test --focus eca.features.chat-test — 72 tests, 468 assertions
  • bb test — 934 tests, 5,374 assertions
  • bb integration-test --dev --ns integration.chat.commands-test — 4 tests, 74 assertions
  • clj-kondo on changed source/tests — 0 errors, 0 warnings
  • Whole-tree clj-kondo only reports the pre-existing unresolved dir in test/eca/features/hooks_test.clj:259

This contribution was prepared with OpenAI Codex assistance.

  • Added an Unreleased changelog entry.

@zikajk

zikajk commented Sep 10, 2026

Copy link
Copy Markdown
Member

@emecii Nice feature, and the happy path is solid! Just one blocker.

Comment thread src/eca/features/commands.clj Outdated
Comment thread src/eca/features/commands.clj
Comment thread docs/config/commands.md
@emecii
emecii force-pushed the fix/custom-command-file-context branch 3 times, most recently from c6d97ff to f1d3391 Compare September 10, 2026 16:07
@emecii
emecii force-pushed the fix/custom-command-file-context branch from f1d3391 to bbbffaf Compare September 12, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Support file content (@) as custom-command arg

2 participants