Avoid usage of org.antlr.runtime.Token.EOF_TOKEN - #3730
Open
HannesWell wants to merge 1 commit into
Open
Conversation
instead check if a Token has the type EOF.
Test Results 8 064 files ±0 8 064 suites ±0 3h 53m 27s ⏱️ + 5m 20s For more details on these failures, see this check. Results for commit 9056ea3. ± Comparison against base commit 7c0ac01. |
szarnekow
reviewed
Jul 1, 2026
| state.text = null; | ||
| if ( input.LA(1)==CharStream.EOF ) { | ||
| return Token.EOF_TOKEN; | ||
| return new CommonToken(Token.EOF); |
Contributor
There was a problem hiding this comment.
Would it make sense to create a CommonToken with correct offset information?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead check if a Token has the type EOF.
This simplifies a potential future migration to the latest ANTLR 3 release since the EOF_Token was removed.
Furthermore I avoids the assumption that the EOF token is always the same instance.
@szarnekow, you mentioned that the latter assumption lead to problems in the past.
Would it be possible to simplify some code with this change being applied.
This is extracted from