Add N&N for LTK copy refactoring - #575
Merged
Merged
Conversation
merks
requested changes
Jul 3, 2026
merks
left a comment
merks
left a comment
Contributor
There was a problem hiding this comment.
This should be in platform_isv.md not in platform.md because it's about APIs used by developers developing plugins, not directly used by the end user.
Please also split sentenced onto new lines.
| - [Felix Schmid](https://github.com/Felix-Schmid) | ||
| </details> | ||
|
|
||
| LTK already supported refactoring operations for moving, renaming, and deleting resources, but part of the infrastructure for copying was missing. Copy participants contributed via the `org.eclipse.ltk.core.refactoring.copyParticipants` extension point are now invoked when resources are copied. |
Contributor
There was a problem hiding this comment.
Please start new sentences on a new line.
Felix-Schmid
force-pushed
the
copy-refactoring-n&n
branch
from
July 3, 2026 09:45
134e456 to
8ab8c02
Compare
merks
requested changes
Jul 3, 2026
merks
left a comment
merks
left a comment
Contributor
There was a problem hiding this comment.
Just small details. Then we can merge. Thanks for your patience! And for contributing this useful new feature!!
|
|
||
| ## Language Toolkit (LTK) | ||
|
|
||
| ### Copy refactoring support |
Contributor
There was a problem hiding this comment.
Title case please.
Suggested change
| ### Copy refactoring support | |
| ### Copy Refactoring Support |
| Copy participants contributed via the `org.eclipse.ltk.core.refactoring.copyParticipants` extension point are now invoked when resources are copied. | ||
|
|
||
| These copy participants can perform refactorings, such as adjusting package names for specific languages. | ||
| For example, the Eclipse 4diac IDE includes a participant that updates package names to match the new folder structure when resources are copied. It can be found [here](https://github.com/eclipse-4diac/4diac-ide/blob/develop/plugins/org.eclipse.fordiac.ide.typemanagement/src/org/eclipse/fordiac/ide/typemanagement/refactoring/copy/CopyTypeParticipant.java). |
Contributor
There was a problem hiding this comment.
Please split these two sentenced into two lines.
Contributor
Author
There was a problem hiding this comment.
Oops, overlooked that one. Done.
Felix-Schmid
force-pushed
the
copy-refactoring-n&n
branch
from
July 3, 2026 11:01
8ab8c02 to
0490b91
Compare
merks
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See eclipse-platform/eclipse.platform.ui#4047