Suggest MiMa-informed Ship edits and fail closed on missing bumps - #142
Merged
Conversation
Min-bump report is a derived zio-json codec. Check and suggest Once jobs are injected when Ship rows are present. MiniJson and the other hand-rolled JSON dumps now use zio-json as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third implementation slice of independent module versioning (
independent-module-versioning.mdPR 3).When Ship rows are present, generate injects two Once jobs:
modver-suggest(sticky PR comment) andmodver-check(fail closed). Both self-compile. The human still writes the catalog number. CI never commits it.JSON in core is now derived zio-json (
0.10.0). MiniJson is gone. Pin inventory, GitHub snapshots, Action JSON, OSV, andzipx-affected.jsonuse the same codecs.What lands
0.y→ minor,1.y→ major, JS-only → patch, first publish → no floor, group max viaminBumpOrdModverReportwritten totarget/zipx-modver-report.json; check and suggest both read it<!-- zipx-modver -->with an optionalsuggestionfencezipxModverCompat/zipxModverCheck/zipxModverSuggestCapability.modverCheck/modverSuggestinjected into the builtin list beforecombineCapabilitieswhenzipxShipsis non-emptymima-core1.1.5 on the plugin classpathProof
core/testFull(696). Plugin compiles, including dogfood.scalafmtCheckAllgreen.Follow-ups (PR 4+): propagate, Graph publish filtered by version-moved, docs/dogfood.