Assign per-module version from Ship rows and keep catalog update off them - #141
Merged
Conversation
…them When ZipxVersions has Ship / ShipGroup rows, each publishing project takes <row>-ci locally. Catalog apply and zipxDepUpdate leave those constructors alone. zipxModverBump rewrites the version literal by tree span and never writes -ci.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second implementation slice of independent module versioning (
independent-module-versioning.mdPR 2).PR 1 added
Ship/ShipGrouprows and fail-closed bump/publish sets. This wires those rows into the plugin: presence of any ship is the feature flag. Empty ships still leavesversionto dynver. Aggregators and unpublished apps get0.1.0-SNAPSHOTinstead of a circularversion.value. Local is always<row>-ci(releasing flags are later).What lands
zipxShips,zipxMatrixRoot,zipxModverBumpZipxVersions.settingsassignsversion := Def.uncachedfrom the matching Ship row (or JS/Native suffix of a root)pomPostProcessstrips-ciso sibling POM revisions are catalog numbersCatalogSourceparsesShip/ curriedShipGroup(0/1/many, includingnew Ship)CatalogApply.applyShipBumpsrewrites the version literal by tree span; missing constructor is Left; never writes-cizipxDepUpdate/ CLIplanUpdateleave Ship constructors alonezipx/modver-settings: mixed versions, POM, catalog isolation,zipxModverBump clientProof
core/testFull(688),syntax/testFull(13),cli/testFull(8),plugin/scripted zipx/modver-settings.syntax/docandplugin/docsucceed (needed forpublishLocal).Follow-ups (PR 3+): MiMa suggest/check jobs, propagate, Graph publish filtered by version-moved.