Add ascent-chekhov typed locators for JSEnv and JVM Page - #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64.
Replaces Chekhov's thin
chekhov-ascentmount bridge in this repo. Tests talk to nodes asInputHandle/ButtonHandleinstead oforg.scalajs.dom.Element.Summary
ascent-chekhov(JVM + JS): sharedHtmlTag/TagHandlelattice, JSEnvwithMounted+ live handles, JVMPageHandlesover ChekhovLocator.fillis only on input-like handles. Catalog vals stay unparameterizedElementKey; passHtmlTag.buttonorroot.button("inc").testJS.PageHandles.getByPlaceholder(..., HtmlTag.input).chekhov-ascentafter the next Ascent release: Remove chekhov-ascent; Ascent owns the mount + typed locators chekhov#38.Test plan
Covered by CI (
ascentChekhovontestJVM;ascentChekhovJS/testFullon the e2e job). Locally:sbt ascentChekhov/testFullsbt "e2e/chekhovInstall; ascentChekhovJS/testFull"sbt e2e/testFull