-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Make Build mode use the agentic loop #4381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c6eef75
Make Build mode use the agentic loop
wwwillchen 1e2147b
Fix verified Build mode review issues
wwwillchen 254a1dc
Address Build mode review feedback
wwwillchen c5502d4
Address follow-up PR feedback
wwwillchen 5686ca0
Address PR review comments
wwwillchen f5c5526
Address PR review comments
wwwillchen 8a40113
Prevent replaying agentic tool actions
wwwillchen 798d541
Address deep review and approval compatibility
wwwillchen 0211822
Fix agentic Build review and E2E coverage
wwwillchen 31839e5
Fix PR feedback and agentic E2E flakes
wwwillchen fe4aa7d
Rebase E2E snapshots for agentic changes
wwwillchen 2e9bffb
Stabilize paused queue resubmission test
wwwillchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 MEDIUM
Legacy proposal approve/reject path loses all remaining test coverage
src/ipc/handlers/__tests__/reject.integration.test.tsis deleted,PageObject.approveProposal/rejectProposalare removed, and every remaining E2E call site (approve,debugging_logs,logs_server,visual_editing,package_manager) now opts into auto-approval instead. The approve/reject code path is still live, though:ChatInputActionsrenders whenevergetProposalreturns non-null, andproposal_handlersdeliberately keeps returning legacy proposals for assistant messages withoutaiMessagesJson— i.e. exactly the pre-upgrade chats this compatibility path exists to serve. That path now ships with no automated coverage at any level, andChatInput.tsxsimultaneously relaxes its render guard by dropping theselectedMode !== "ask" && selectedMode !== "local-agent"condition.💡 Suggestion: Keep one integration test that seeds an assistant message with legacy XML content and a null
aiMessagesJson, then drives the real Approve and Reject buttons, so the stored-response compatibility path stays verified.