Skip to content
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
489 changes: 489 additions & 0 deletions plans/sandboxed-e2e-test-runtime.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/atoms/testRuntimeAtoms.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export type TestRunPhase =
| "setup" // first-run Playwright bootstrap streaming
| "running" // playwright test executing
| "stopping" // Stop pressed; killing the Playwright process tree
| "cleaning-up"; // tests gone; isolation teardown still restoring the app
| "cleaning-up"; // tests gone; isolated provider data is still being removed
Comment thread
azizmejri1 marked this conversation as resolved.

export interface TestRunState {
phase: TestRunPhase;
Expand Down
2 changes: 2 additions & 0 deletions src/ipc/handlers/app_handlers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ import {
trackedBranchId,
} from "../utils/neon_test_branch";
import type { AppSearchResult } from "@/lib/schemas";
import { endTestsForApp } from "./tests_handlers";

import {
getRgExecutablePath,
Expand Down Expand Up @@ -491,6 +492,7 @@ async function deleteAppById(
const { envRestored } = await endRecordingForApp(appId, "app-stopped", {
skipRestart: true,
});
await endTestsForApp(appId);
if (!envRestored) {
// The app directory is about to be removed, so a stale `.env.local`
// inside it goes with it — this is diagnosis, not a refusal.
Expand Down
Loading
Loading